Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jupyter deps to Pipfile.lock #2419

Merged
merged 1 commit into from Aug 16, 2021
Merged

Add jupyter deps to Pipfile.lock #2419

merged 1 commit into from Aug 16, 2021

Conversation

MarcoGorelli
Copy link
Contributor

xref #2413

I added jupyter to Pipfile and then, in a new virtual environment, ran pipenv install --dev, and committed. Is this what's required for that issue?

@ichard26 ichard26 added the skip news Pull requests that don't need a changelog entry. label Aug 10, 2021
ichard26
ichard26 approved these changes Aug 16, 2021
View reviewed changes
Copy link
Collaborator

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! Thank you!

P.S. the reason why I wanted the jupyter deps in here is to reduce friction when contributing. You shouldn't have to reinstall black with the jupyter extra just to test your ipynb changes ^^

@ichard26 ichard26 changed the title Pipfile lock Add jupyter deps to Pipfile.lock Aug 16, 2021
@ichard26 ichard26 merged commit b92ec34 into psf:main Aug 16, 2021
@MarcoGorelli MarcoGorelli deleted the jupyter-pipfile-lock branch August 17, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichard26 ichard26 ichard26 approved these changes

Assignees
No one assigned
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarcoGorelli @ichard26