New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker image usage description #2412
Conversation
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All sounds good to me. Many thanks for this! Once @JelleZijlstra is happy lets merge.
### Check Black version | ||
|
||
```console | ||
$ docker run --rm pyfound/black:latest_release black --version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could state --rm is optional, but not needed I don't think really needed. If I was running black a lot on the box I'd leave the container up and execute out of it. But depends on your use case :)
$ docker run --rm pyfound/black:latest_release black --version | |
$ docker run [--rm] pyfound/black:latest_release black --version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cooperlees - sorry for answering late. I was on vacation with very limited access to the Internet.
I believe Black image is not prepared for constantly running in the background. Nevertheless container can be created with all needed customizations (volume mounting etc.) and started when needed. But it means you have to store your source code always in the same place, so volume mounting works. Or you should have separate container for every place with source code with different volume mounting set.
That's why in provided examples container is removed after command is completed. Of course this is only suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for dropping this for a while! I have a few more wording suggestions.
As mentioned by @cooperlees I described Docker image tags and provided two basic examples of Docker image usage.
Please note that I'm not native English speaker, so be forgiving 馃榾