Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix for issue with indentation and fmt: skip #2281

Merged
merged 5 commits into from Jun 8, 2021

Commits on Jun 2, 2021

  1. Fix issue with fmt: skip (psf#2254)

    Not sure the fix is right.  Here is what I found: issue is connected
    with line
    
        first.prefix = prefix[comment.consumed :]
    
    in `comments.py`.  `first.prefix` is a prefix of the line, that ends
    with `# fmt: skip`, but `comment.consumed` is the length of the
    `"  # fmt: skip"` string.  If prefix length is greater than 14,
    `first.prefix` will grow every time we apply formatting.
    enzet committed Jun 2, 2021
    Copy the full SHA
    2e4ac3e View commit details
    Browse the repository at this point in the history
  2. Add test for fmt: skip

    Test for fmt: skip comment when indentation needs more than 14 spaces.
    enzet committed Jun 2, 2021
    Copy the full SHA
    8ec7e32 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    c64768c View commit details
    Browse the repository at this point in the history
  4. Add output to test

    enzet committed Jun 2, 2021
    Copy the full SHA
    4d9565b View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2021

  1. Copy the full SHA
    737b00d View commit details
    Browse the repository at this point in the history