Parenthesize conditional expressions

CHANGES.md

@@ -10,6 +10,7 @@
   `.gitignore` rules like `git` does) (#2225)
 - Restored compatibility with Click 8.0 on Python 3.6 when LANG=C used (#2227)
 - Add extra uvloop install + import support if in python env (#2258)
+- Multiline conditional expressions are now always parenthesized (#2278)
 
 ### _Blackd_
 

src/black/linegen.py

@@ -100,6 +100,25 @@ def visit_default(self, node: LN) -> Iterator[Line]:
                 self.current_line.append(node)
         yield from super().visit_default(node)
 
+    def visit_test(self, node: Node) -> Iterator[Line]:
+        """Visit an `x if y else z` test"""
+
+        # parenthesize conditional expressions which span multiple lines
+        already_parenthesized = (
+            node.prev_sibling and node.prev_sibling.type == token.LPAR
+        )
+        as_str = str(node)
+        multiline = "\n" in as_str and not (
+            as_str.startswith("\n") or as_str.endswith("\n")
+        )
+        if not already_parenthesized and multiline:
+            lpar = Leaf(token.LPAR, "(")
+            rpar = Leaf(token.RPAR, ")")
+            node.insert_child(0, lpar)
+            node.append_child(rpar)
+
+        yield from self.visit_default(node)
+
     def visit_INDENT(self, node: Leaf) -> Iterator[Line]:
         """Increase indentation level, maybe yield a line."""
         # In blib2to3 INDENT never holds comments.

tests/data/conditional_expression_kwargs.py

@@ -0,0 +1,19 @@
+aaa = my_function(
+    foo="test, this is a sample value",
+    bar=some_long_value_name_foo_bar_baz
+    if some_boolean_variable
+    else some_fallback_value_foo_bar_baz,
+    baz="hello, this is a another value",
+)
+
+# output
+
+aaa = my_function(
+    foo="test, this is a sample value",
+    bar=(
+        some_long_value_name_foo_bar_baz
+        if some_boolean_variable
+        else some_fallback_value_foo_bar_baz
+    ),
+    baz="hello, this is a another value",
+)

tests/test_format.py

@@ -29,6 +29,7 @@
     "comment_after_escaped_newline",
     "composition",
     "composition_no_trailing_comma",
+    "conditional_expression_kwargs",
     "docstring",
     "empty_lines",
     "expression",