New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link isort profile to Black code style mention #2246
Conversation
Thanks for the heads up! I'll review this soon, just a little busy today. Although, what is CI doing!? Why is everything cancelled? I guess it's because they're all very stuck. Nevermind... there's an active incident with GitHub Actions. Time to wait then huh. |
It seems that the issue is resolved and Actions is recovering! |
I reran the jobs and they still failed. I don't think GHA has fully recovered yet :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! LGTM, I like reducing duplication in the docs :)
Is that profile considered part of black's style or isort? I'd like to bring up for discussion the idea of changing that profile to use However, I'm not sure if I should bring it up here, or it |
It's probably better if you bring it up on the isort issue tracker since we don't know isort well. I had to search up with I wouldn't mind being CCed in though. |
yeah, imports were a major source of merge conflicts in pandas, setting
pretty sure this would be isort, as that's where the profile's defined |
I've opened an issue to discuss the topic on the isort side. |
Hi, the isort configuration currently in the Black code style document is duplicated in Using Black with other tools. I think it would be better to consolidate information and simply link to the tool guide, mentioning the easy profile in the original document.
I think
skip news
, what do you think about the change?I changed the link to isort PyPI page because for users it could be better to see the Black docs on why that configuration is necessary and what isort is from Black's perspective.