Provide a more useful error when parsing fails during AST safety checks (#2218) #2218
Conversation
| try: | ||
| return ast27.parse(src) | ||
| except SyntaxError as e: | ||
| raise SyntaxError(error or str(e)) |
There was a problem hiding this comment.
Firstly, thanks for the PR!
If I'm not mistaken, this means that 2.7 errors are never passed onwards. To get to this try some other try above must fail, then error always has a value and the or short circuits. Indeed this only ever prints the error for Python 3.6, because it's the last to fail before 2.7. So this moves the problem from 2.7 to 3.6, but I'm pretty sure this is not quite the optimal solution.
The linked issue spoke of reparsing with the latest Python version available, and that idea had some agreement. That could be possible using sys.version_info and iffing the parser versions again.
|
Reading the issue once more, my previous review was a bit off the mark still. But I took your branch and improved on it in the referenced PR above. Many thanks for the initial work! |
|
Felix's PR (#2304) which is based off this work has been merged now so this will be closed. Thank you for the initial work @hramezani! Your ideas will continue to live in this codebase :) |
|
Thanks @felix-hilden for taking care |
Fixes #2178