New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stability fixup: address stability issues relating to interaction between magic commas and invisible parentheses #1958
Stability fixup: address stability issues relating to interaction between magic commas and invisible parentheses #1958
Commits on Feb 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for fa0b64d - Browse repository at this point
Copy the full SHA fa0b64dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 21842f2 - Browse repository at this point
Copy the full SHA 21842f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdff084 - Browse repository at this point
Copy the full SHA fdff084View commit details -
Use a 'pass' statement since 'maybe_make_parens_invisible_in_atom' cu…
…rrently always returns False for non-atom nodes, making the 'wrap_in_parentheses' call unreachable
Configuration menu - View commit details
-
Copy full SHA for 0bb718c - Browse repository at this point
Copy the full SHA 0bb718cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 82ab09d - Browse repository at this point
Copy the full SHA 82ab09dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f154042 - Browse repository at this point
Copy the full SHA f154042View commit details -
Configuration menu - View commit details
-
Copy full SHA for d262d29 - Browse repository at this point
Copy the full SHA d262d29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23facce - Browse repository at this point
Copy the full SHA 23facceView commit details -
Update primer.json to permit formatting changes to be passed by conti…
…nuous integration
Configuration menu - View commit details
-
Copy full SHA for 543fc7e - Browse repository at this point
Copy the full SHA 543fc7eView commit details
Commits on Feb 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 27e1f05 - Browse repository at this point
Copy the full SHA 27e1f05View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c6d262 - Browse repository at this point
Copy the full SHA 6c6d262View commit details -
Add additional test cases from #1629
These are generally cases where example code was provided by a user and it was straightforward to copy and confirm the stability test failure for that code
Configuration menu - View commit details
-
Copy full SHA for 2152848 - Browse repository at this point
Copy the full SHA 2152848View commit details -
Revert "Temporarily revert src directory changes"
This reverts commit 6c6d262.
Configuration menu - View commit details
-
Copy full SHA for a23e87d - Browse repository at this point
Copy the full SHA a23e87dView commit details -
Revert "Update primer.json to permit formatting changes to be passed …
…by continuous integration" This reverts commit 543fc7e.
Configuration menu - View commit details
-
Copy full SHA for 065abbf - Browse repository at this point
Copy the full SHA 065abbfView commit details -
Revert "Cleanup: remove redundant code path"
This reverts commit 23facce.
Configuration menu - View commit details
-
Copy full SHA for 10015f6 - Browse repository at this point
Copy the full SHA 10015f6View commit details -
Revert "Update output expectation for trailing comma reformatting tes…
…t case" This reverts commit d262d29.
Configuration menu - View commit details
-
Copy full SHA for 16bf728 - Browse repository at this point
Copy the full SHA 16bf728View commit details -
Revert "Cleanup: remove slightly arbitrary 'pass' handling for assert…
… and return statements" This reverts commit f154042.
Configuration menu - View commit details
-
Copy full SHA for f4ee9dc - Browse repository at this point
Copy the full SHA f4ee9dcView commit details -
Revert "Do not omit any tokens when selecting the last two leaves"
This reverts commit 82ab09d.
Configuration menu - View commit details
-
Copy full SHA for 4c2947f - Browse repository at this point
Copy the full SHA 4c2947fView commit details -
Revert "Use a 'pass' statement since 'maybe_make_parens_invisible_in_…
…atom' currently always returns False for non-atom nodes, making the 'wrap_in_parentheses' call unreachable" This reverts commit 0bb718c.
Configuration menu - View commit details
-
Copy full SHA for 461a828 - Browse repository at this point
Copy the full SHA 461a828View commit details -
Revert "Re-enable test_trailing_comma_optional_parens_stability3 sinc…
…e it has stabilized" This reverts commit fdff084.
Configuration menu - View commit details
-
Copy full SHA for 07f5796 - Browse repository at this point
Copy the full SHA 07f5796View commit details -
Revert "Fixup: handling of invisible parentheses for assert and retur…
…n statements" This reverts commit 21842f2.
Configuration menu - View commit details
-
Copy full SHA for 39caefb - Browse repository at this point
Copy the full SHA 39caefbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c1482d - Browse repository at this point
Copy the full SHA 7c1482dView commit details -
Indicate that failures are expected in the 'test_invisible_parens_ins…
…tability' case until a resolution is found
Configuration menu - View commit details
-
Copy full SHA for ab07b03 - Browse repository at this point
Copy the full SHA ab07b03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1109e33 - Browse repository at this point
Copy the full SHA 1109e33View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6eab7c - Browse repository at this point
Copy the full SHA f6eab7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d4a2e36 - Browse repository at this point
Copy the full SHA d4a2e36View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebbd3e8 - Browse repository at this point
Copy the full SHA ebbd3e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d806503 - Browse repository at this point
Copy the full SHA d806503View commit details -
Simplification: only use special-case token retrieval logic when magi…
…c trailing comma is present
Configuration menu - View commit details
-
Copy full SHA for 7dba4ba - Browse repository at this point
Copy the full SHA 7dba4baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 27a2dfe - Browse repository at this point
Copy the full SHA 27a2dfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a45017 - Browse repository at this point
Copy the full SHA 3a45017View commit details -
Merge branch 'refactor/distinguished-variable-responsibilities' into …
…stability/invisible-parens-assert-return
Configuration menu - View commit details
-
Copy full SHA for 4ff708f - Browse repository at this point
Copy the full SHA 4ff708fView commit details
Commits on Feb 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 95677ff - Browse repository at this point
Copy the full SHA 95677ffView commit details -
Revert "Address pre-existing trailing commas when not in the rightmos…
…t bracket pair" This reverts commit 586d242.
Configuration menu - View commit details
-
Copy full SHA for e9a7326 - Browse repository at this point
Copy the full SHA e9a7326View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b997a8 - Browse repository at this point
Copy the full SHA 8b997a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec1b0ab - Browse repository at this point
Copy the full SHA ec1b0abView commit details -
Revert "Work-in-progress: investigate bracket matching"
This reverts commit ec1b0ab.
Configuration menu - View commit details
-
Copy full SHA for b90268e - Browse repository at this point
Copy the full SHA b90268eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 268e3f3 - Browse repository at this point
Copy the full SHA 268e3f3View commit details -
Use a 'pass' statement since 'maybe_make_parens_invisible_in_atom' cu…
…rrently always returns False for non-atom nodes, making the 'wrap_in_parentheses' call unreachable
Configuration menu - View commit details
-
Copy full SHA for 0596b38 - Browse repository at this point
Copy the full SHA 0596b38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58c3cce - Browse repository at this point
Copy the full SHA 58c3cceView commit details
Commits on Feb 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 235b854 - Browse repository at this point
Copy the full SHA 235b854View commit details
Commits on Feb 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e245b1a - Browse repository at this point
Copy the full SHA e245b1aView commit details -
When a magic comma is present in the line, delay emission of empty tr…
…ailer until the comma is encountered
Configuration menu - View commit details
-
Copy full SHA for acffae3 - Browse repository at this point
Copy the full SHA acffae3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d036da4 - Browse repository at this point
Copy the full SHA d036da4View commit details -
Add special-case handling of 'if' statements within normalize_invisib…
…le_parens method
Configuration menu - View commit details
-
Copy full SHA for 7da423e - Browse repository at this point
Copy the full SHA 7da423eView commit details -
When a magic comma is present in the line, emit an empty trailer when…
… we encounter closed brackets with inner brackets
Configuration menu - View commit details
-
Copy full SHA for 634b1a3 - Browse repository at this point
Copy the full SHA 634b1a3View commit details -
black-primer configuration: indicate that sqlalchemy would require fo…
…rmatting updates under this changeset
Configuration menu - View commit details
-
Copy full SHA for e8ad631 - Browse repository at this point
Copy the full SHA e8ad631View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48ac43f - Browse repository at this point
Copy the full SHA 48ac43fView commit details -
Revert "Add additional test cases from #1629"
This reverts commit 2152848.
Configuration menu - View commit details
-
Copy full SHA for 62b76ca - Browse repository at this point
Copy the full SHA 62b76caView commit details -
black-primer configuration: indicate that flake8-bugbear would requir…
…e formatting updates under this changeset
Configuration menu - View commit details
-
Copy full SHA for 9ff5f98 - Browse repository at this point
Copy the full SHA 9ff5f98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 176a96a - Browse repository at this point
Copy the full SHA 176a96aView commit details -
Apply test organization patterns from e6cd10e for 'invisible_parens_i…
…nstability' test
Configuration menu - View commit details
-
Copy full SHA for b93b955 - Browse repository at this point
Copy the full SHA b93b955View commit details -
Nitpick: rename the test; it should be considered a test of stability…
…, not a test of instability
Configuration menu - View commit details
-
Copy full SHA for e96a683 - Browse repository at this point
Copy the full SHA e96a683View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6763046 - Browse repository at this point
Copy the full SHA 6763046View commit details
Commits on Feb 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0aa8083 - Browse repository at this point
Copy the full SHA 0aa8083View commit details
Commits on Feb 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for efc7552 - Browse repository at this point
Copy the full SHA efc7552View commit details -
Merge branch 'refactor/distinguished-variable-responsibilities' into …
…stability/invisible-parens-assert-return
Configuration menu - View commit details
-
Copy full SHA for 0666fc1 - Browse repository at this point
Copy the full SHA 0666fc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2a4a29 - Browse repository at this point
Copy the full SHA b2a4a29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 934c79d - Browse repository at this point
Copy the full SHA 934c79dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c16e29a - Browse repository at this point
Copy the full SHA c16e29aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dfb59a - Browse repository at this point
Copy the full SHA 7dfb59aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a62b47a - Browse repository at this point
Copy the full SHA a62b47aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6423a8d - Browse repository at this point
Copy the full SHA 6423a8dView commit details -
Merge branch 'refactor/distinguished-variable-responsibilities' into …
…stability/invisible-parens-assert-return
Configuration menu - View commit details
-
Copy full SHA for 82ca108 - Browse repository at this point
Copy the full SHA 82ca108View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8343663 - Browse repository at this point
Copy the full SHA 8343663View commit details -
Cleanup: undo accidental changes to remainder logic in '_can_omit_ope…
…ning_paren' method
Configuration menu - View commit details
-
Copy full SHA for 66ef77a - Browse repository at this point
Copy the full SHA 66ef77aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4126cdd - Browse repository at this point
Copy the full SHA 4126cddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34cce10 - Browse repository at this point
Copy the full SHA 34cce10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fcfcbf - Browse repository at this point
Copy the full SHA 8fcfcbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0adad3a - Browse repository at this point
Copy the full SHA 0adad3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 788002a - Browse repository at this point
Copy the full SHA 788002aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 879cbe2 - Browse repository at this point
Copy the full SHA 879cbe2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7d7f59 - Browse repository at this point
Copy the full SHA c7d7f59View commit details
Commits on Feb 10, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9f0289a - Browse repository at this point
Copy the full SHA 9f0289aView commit details -
Merge branch 'refactor/distinguished-variable-responsibilities' into …
…stability/invisible-parens-assert-return
Configuration menu - View commit details
-
Copy full SHA for 4d39520 - Browse repository at this point
Copy the full SHA 4d39520View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4c9238 - Browse repository at this point
Copy the full SHA b4c9238View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bb74e0 - Browse repository at this point
Copy the full SHA 6bb74e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 695ecf1 - Browse repository at this point
Copy the full SHA 695ecf1View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb4ce1b - Browse repository at this point
Copy the full SHA cb4ce1bView commit details -
black-primer configuration: indicate that tox would require formattin…
…g updates under this changeset
Configuration menu - View commit details
-
Copy full SHA for 7f3375f - Browse repository at this point
Copy the full SHA 7f3375fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a8df515 - Browse repository at this point
Copy the full SHA a8df515View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae519ca - Browse repository at this point
Copy the full SHA ae519caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 630771a - Browse repository at this point
Copy the full SHA 630771aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 169ef38 - Browse repository at this point
Copy the full SHA 169ef38View commit details -
Configuration menu - View commit details
-
Copy full SHA for c74a1c5 - Browse repository at this point
Copy the full SHA c74a1c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15788c5 - Browse repository at this point
Copy the full SHA 15788c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f8673d - Browse repository at this point
Copy the full SHA 3f8673dView commit details -
Include 'BracketMatchError' exception handler and comment from 586d242,…
… so that it remains clear that there is a known issue
Configuration menu - View commit details
-
Copy full SHA for 4d5ba05 - Browse repository at this point
Copy the full SHA 4d5ba05View commit details
Commits on Feb 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8c19ff5 - Browse repository at this point
Copy the full SHA 8c19ff5View commit details
Commits on Feb 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7c4a6a0 - Browse repository at this point
Copy the full SHA 7c4a6a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1096bc9 - Browse repository at this point
Copy the full SHA 1096bc9View commit details
Commits on Feb 13, 2021
-
Merge branch 'cleanup/remove-special-case-invisible-parens-handling' …
…into stability/invisible-parens-assert-return
Configuration menu - View commit details
-
Copy full SHA for e04ed95 - Browse repository at this point
Copy the full SHA e04ed95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16d2505 - Browse repository at this point
Copy the full SHA 16d2505View commit details -
Update test expectations (note: this includes output that exceeds the…
… line length limit)
Configuration menu - View commit details
-
Copy full SHA for fe64f19 - Browse repository at this point
Copy the full SHA fe64f19View commit details -
Configuration menu - View commit details
-
Copy full SHA for b061589 - Browse repository at this point
Copy the full SHA b061589View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60d5191 - Browse repository at this point
Copy the full SHA 60d5191View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b10579 - Browse repository at this point
Copy the full SHA 6b10579View commit details -
Configuration menu - View commit details
-
Copy full SHA for eab9b2b - Browse repository at this point
Copy the full SHA eab9b2bView commit details -
black-primer configuration: indicate that tox would not require forma…
…tting updates under this changeset
Configuration menu - View commit details
-
Copy full SHA for c2bf24b - Browse repository at this point
Copy the full SHA c2bf24bView commit details -
black-primer configuration: indicate that bandersnatch would require …
…formatting updates under this changeset
Configuration menu - View commit details
-
Copy full SHA for 0956060 - Browse repository at this point
Copy the full SHA 0956060View commit details
Commits on Feb 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ae45ee3 - Browse repository at this point
Copy the full SHA ae45ee3View commit details
Commits on Feb 17, 2021
-
Cleanup: remove 'test_function' test case; formatting of the 'functio…
…n' test module is covered by the 'test_simple_format' test case
Configuration menu - View commit details
-
Copy full SHA for b0aaff0 - Browse repository at this point
Copy the full SHA b0aaff0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10d56e5 - Browse repository at this point
Copy the full SHA 10d56e5View commit details
Commits on Feb 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3dabcc3 - Browse repository at this point
Copy the full SHA 3dabcc3View commit details
Commits on Feb 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 17e9540 - Browse repository at this point
Copy the full SHA 17e9540View commit details -
Undo method signature changes to 'can_omit_invisible_parens' since it…
… is public library method by naming convention
Configuration menu - View commit details
-
Copy full SHA for 5386773 - Browse repository at this point
Copy the full SHA 5386773View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7bec57 - Browse repository at this point
Copy the full SHA f7bec57View commit details
Commits on Feb 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 5a2111a - Browse repository at this point
Copy the full SHA 5a2111aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cc7102 - Browse repository at this point
Copy the full SHA 3cc7102View commit details
Commits on Feb 27, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d868154 - Browse repository at this point
Copy the full SHA d868154View commit details
Commits on Feb 28, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 47fc731 - Browse repository at this point
Copy the full SHA 47fc731View commit details
Commits on Mar 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 372b74c - Browse repository at this point
Copy the full SHA 372b74cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b48e35c - Browse repository at this point
Copy the full SHA b48e35cView commit details
Commits on Apr 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for bab0899 - Browse repository at this point
Copy the full SHA bab0899View commit details