Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stability fixup: address stability issues relating to interaction between magic commas and invisible parentheses #1958

Closed
wants to merge 114 commits into from
Closed

Stability fixup: address stability issues relating to interaction between magic commas and invisible parentheses #1958

wants to merge 114 commits into from

Commits on Feb 3, 2021

  1. Configuration menu
    Copy the full SHA
    fa0b64d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    21842f2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fdff084 View commit details
    Browse the repository at this point in the history
  4. Use a 'pass' statement since 'maybe_make_parens_invisible_in_atom' cu…

    …rrently always returns False for non-atom nodes, making the 'wrap_in_parentheses' call unreachable
    jayaddison committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    0bb718c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    82ab09d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f154042 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d262d29 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    23facce View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    543fc7e View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. Configuration menu
    Copy the full SHA
    27e1f05 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6c6d262 View commit details
    Browse the repository at this point in the history
  3. Add additional test cases from #1629

    These are generally cases where example code was provided by a user and it was straightforward to copy and confirm the stability test failure for that code
    jayaddison committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    2152848 View commit details
    Browse the repository at this point in the history
  4. Revert "Temporarily revert src directory changes"

    This reverts commit 6c6d262.
    jayaddison committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    a23e87d View commit details
    Browse the repository at this point in the history
  5. Revert "Update primer.json to permit formatting changes to be passed …

    …by continuous integration"
    
    This reverts commit 543fc7e.
    jayaddison committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    065abbf View commit details
    Browse the repository at this point in the history
  6. Revert "Cleanup: remove redundant code path"

    This reverts commit 23facce.
    jayaddison committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    10015f6 View commit details
    Browse the repository at this point in the history
  7. Revert "Update output expectation for trailing comma reformatting tes…

    …t case"
    
    This reverts commit d262d29.
    jayaddison committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    16bf728 View commit details
    Browse the repository at this point in the history
  8. Revert "Cleanup: remove slightly arbitrary 'pass' handling for assert…

    … and return statements"
    
    This reverts commit f154042.
    jayaddison committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    f4ee9dc View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4c2947f View commit details
    Browse the repository at this point in the history
  10. Revert "Use a 'pass' statement since 'maybe_make_parens_invisible_in_…

    …atom' currently always returns False for non-atom nodes, making the 'wrap_in_parentheses' call unreachable"
    
    This reverts commit 0bb718c.
    jayaddison committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    461a828 View commit details
    Browse the repository at this point in the history
  11. Revert "Re-enable test_trailing_comma_optional_parens_stability3 sinc…

    …e it has stabilized"
    
    This reverts commit fdff084.
    jayaddison committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    07f5796 View commit details
    Browse the repository at this point in the history
  12. Revert "Fixup: handling of invisible parentheses for assert and retur…

    …n statements"
    
    This reverts commit 21842f2.
    jayaddison committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    39caefb View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    7c1482d View commit details
    Browse the repository at this point in the history
  14. Indicate that failures are expected in the 'test_invisible_parens_ins…

    …tability' case until a resolution is found
    jayaddison committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    ab07b03 View commit details
    Browse the repository at this point in the history
  15. Brevity: rename method

    jayaddison committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    1109e33 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    f6eab7c View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    d4a2e36 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    ebbd3e8 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    d806503 View commit details
    Browse the repository at this point in the history
  20. Simplification: only use special-case token retrieval logic when magi…

    …c trailing comma is present
    jayaddison committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    7dba4ba View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    27a2dfe View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    3a45017 View commit details
    Browse the repository at this point in the history
  23. Merge branch 'refactor/distinguished-variable-responsibilities' into …

    …stability/invisible-parens-assert-return
    jayaddison committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    4ff708f View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. Configuration menu
    Copy the full SHA
    95677ff View commit details
    Browse the repository at this point in the history
  2. Revert "Address pre-existing trailing commas when not in the rightmos…

    …t bracket pair"
    
    This reverts commit 586d242.
    jayaddison committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    e9a7326 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8b997a8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ec1b0ab View commit details
    Browse the repository at this point in the history
  5. Revert "Work-in-progress: investigate bracket matching"

    This reverts commit ec1b0ab.
    jayaddison committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    b90268e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    268e3f3 View commit details
    Browse the repository at this point in the history
  7. Use a 'pass' statement since 'maybe_make_parens_invisible_in_atom' cu…

    …rrently always returns False for non-atom nodes, making the 'wrap_in_parentheses' call unreachable
    jayaddison committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    0596b38 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    58c3cce View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2021

  1. Configuration menu
    Copy the full SHA
    235b854 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2021

  1. Configuration menu
    Copy the full SHA
    e245b1a View commit details
    Browse the repository at this point in the history
  2. When a magic comma is present in the line, delay emission of empty tr…

    …ailer until the comma is encountered
    jayaddison committed Feb 7, 2021
    Configuration menu
    Copy the full SHA
    acffae3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d036da4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7da423e View commit details
    Browse the repository at this point in the history
  5. When a magic comma is present in the line, emit an empty trailer when…

    … we encounter closed brackets with inner brackets
    jayaddison committed Feb 7, 2021
    Configuration menu
    Copy the full SHA
    634b1a3 View commit details
    Browse the repository at this point in the history
  6. black-primer configuration: indicate that sqlalchemy would require fo…

    …rmatting updates under this changeset
    jayaddison committed Feb 7, 2021
    Configuration menu
    Copy the full SHA
    e8ad631 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    48ac43f View commit details
    Browse the repository at this point in the history
  8. Revert "Add additional test cases from #1629"

    This reverts commit 2152848.
    jayaddison committed Feb 7, 2021
    Configuration menu
    Copy the full SHA
    62b76ca View commit details
    Browse the repository at this point in the history
  9. black-primer configuration: indicate that flake8-bugbear would requir…

    …e formatting updates under this changeset
    jayaddison committed Feb 7, 2021
    Configuration menu
    Copy the full SHA
    9ff5f98 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    176a96a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b93b955 View commit details
    Browse the repository at this point in the history
  12. Nitpick: rename the test; it should be considered a test of stability…

    …, not a test of instability
    jayaddison committed Feb 7, 2021
    Configuration menu
    Copy the full SHA
    e96a683 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    6763046 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. Configuration menu
    Copy the full SHA
    0aa8083 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Configuration menu
    Copy the full SHA
    efc7552 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'refactor/distinguished-variable-responsibilities' into …

    …stability/invisible-parens-assert-return
    jayaddison committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    0666fc1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b2a4a29 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    934c79d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c16e29a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7dfb59a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a62b47a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6423a8d View commit details
    Browse the repository at this point in the history
  9. Merge branch 'refactor/distinguished-variable-responsibilities' into …

    …stability/invisible-parens-assert-return
    jayaddison committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    82ca108 View commit details
    Browse the repository at this point in the history
  10. Remove empty line

    jayaddison committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    8343663 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    66ef77a View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    4126cdd View commit details
    Browse the repository at this point in the history
  13. Restore empty line

    jayaddison committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    34cce10 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    8fcfcbf View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    0adad3a View commit details
    Browse the repository at this point in the history
  16. Restore empty line

    jayaddison committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    788002a View commit details
    Browse the repository at this point in the history
  17. Remove empty line

    jayaddison committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    879cbe2 View commit details
    Browse the repository at this point in the history
  18. Restore accurate comment

    jayaddison committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    c7d7f59 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. Configuration menu
    Copy the full SHA
    9f0289a View commit details
    Browse the repository at this point in the history
  2. Merge branch 'refactor/distinguished-variable-responsibilities' into …

    …stability/invisible-parens-assert-return
    jayaddison committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    4d39520 View commit details
    Browse the repository at this point in the history
  3. Update test expectations

    jayaddison committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    b4c9238 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6bb74e0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    695ecf1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cb4ce1b View commit details
    Browse the repository at this point in the history
  7. black-primer configuration: indicate that tox would require formattin…

    …g updates under this changeset
    jayaddison committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    7f3375f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a8df515 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ae519ca View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    630771a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    169ef38 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c74a1c5 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    15788c5 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    3f8673d View commit details
    Browse the repository at this point in the history
  15. Include 'BracketMatchError' exception handler and comment from 586d242,…

    … so that it remains clear that there is a known issue
    jayaddison committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    4d5ba05 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. Configuration menu
    Copy the full SHA
    8c19ff5 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2021

  1. Configuration menu
    Copy the full SHA
    7c4a6a0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1096bc9 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2021

  1. Merge branch 'cleanup/remove-special-case-invisible-parens-handling' …

    …into stability/invisible-parens-assert-return
    jayaddison committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    e04ed95 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    16d2505 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fe64f19 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b061589 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    60d5191 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6b10579 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    eab9b2b View commit details
    Browse the repository at this point in the history
  8. black-primer configuration: indicate that tox would not require forma…

    …tting updates under this changeset
    jayaddison committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    c2bf24b View commit details
    Browse the repository at this point in the history
  9. black-primer configuration: indicate that bandersnatch would require …

    …formatting updates under this changeset
    jayaddison committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    0956060 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. Configuration menu
    Copy the full SHA
    ae45ee3 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. Cleanup: remove 'test_function' test case; formatting of the 'functio…

    …n' test module is covered by the 'test_simple_format' test case
    jayaddison committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    b0aaff0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    10d56e5 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2021

  1. Configuration menu
    Copy the full SHA
    3dabcc3 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2021

  1. Configuration menu
    Copy the full SHA
    17e9540 View commit details
    Browse the repository at this point in the history
  2. Undo method signature changes to 'can_omit_invisible_parens' since it…

    … is public library method by naming convention
    jayaddison committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    5386773 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f7bec57 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Configuration menu
    Copy the full SHA
    5a2111a View commit details
    Browse the repository at this point in the history
  2. Add changelog entry

    jayaddison committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    3cc7102 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2021

  1. Configuration menu
    Copy the full SHA
    d868154 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2021

  1. Configuration menu
    Copy the full SHA
    47fc731 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. Configuration menu
    Copy the full SHA
    372b74c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b48e35c View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. Configuration menu
    Copy the full SHA
    bab0899 View commit details
    Browse the repository at this point in the history