New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speed up cache by approximately 42x by avoiding pathlib #1953
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - Crazy increase. Expensive object this pathlib :D.
(will let some others look before merging)
Looks like Travis is just never finishing, do we still need it? |
And thanks for catching and fixing this! |
Travis CI for Open Source is shutting down in a few weeks so the queue for jobs is insane due to lower resources. I'm 99.99% sure we don't need it as our Test, Lint, Docs, Upload / Package, Primer, and Fuzz workflows are all on GitHub Actions. So even though we can migrate to the .com version with its 1000 free Linux minutes(?), I don't think we need to. (more info here, here, and also here) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might need a change log entry, but other than that LGTM, thanks!
edit: maybe when cache operations are done per run rather than per file in another PR, we can add the changelog entry along the lines of "Caching overhead when formatting large quantities of files has been significantly reduced" that covers both PRs including this one
edit 2: I can't read emails apparently, Black's caching DOES NOT behave how I described it as above ... today isn't a good day for me lol
added the changelog entry |
resolves #1950