Use Prettier pre-commit mirror #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Prettier install failures similar to those seen in prettier/prettier#9459, and is the solution recommended there. Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
|
Thanks for this. Let's see how happy CI is. Just want to say, |
|
This is actually batching up two moves. Prettier had already moved their pre-commit support to https://github.com/prettier/pre-commit, and then this split-out was (I assume) handed over to the pre-commit team to maintain. |
|
CI seems happy. Looking at the logs, I guess it's been reusing the existing Prettier environment (since it only installed the changed Prettier, not the other environments), so this breakage might have been around silently for a little while. |
cooperlees
approved these changes
Jan 1, 2021
noxan
pushed a commit
to noxan/black
that referenced
this pull request
Jun 6, 2021
This fixes Prettier install failures similar to those seen in prettier/prettier#9459, and is the solution recommended there. Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Prettier install failures similar to those seen in prettier/prettier#9459, and is the solution recommended there.