Add pyi file support to .pre-commit-hooks.yaml #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichard26
approved these changes
Dec 20, 2020
|
Perhaps it would be good to also put |
|
Agree with @MarcoGorelli, I'd be worried this causes issues for people running an earlier version of pre-commit. |
Since pre-commit 2.9.0 (2020-11-21), the types_or key can be used to match multiple disparate file types. For more upstream details, see: pre-commit/pre-commit#607 Add the minimum_pre_commit_version to require pre-commit 2.9.0+. Fixes #402
Thank you for this suggestion. I like it. Included in the latest revision. The quotes are not necessary as having multiple "." is an invalid number so YAML automatically interprets it as a string. |
cooperlees
approved these changes
Dec 31, 2020
asottile
reviewed
Dec 31, 2020
| @@ -8,8 +8,9 @@ repos: | |||
| name: black | |||
| language: system | |||
| entry: black | |||
| minimum_pre_commit_version: 2.9.0 | |||
There was a problem hiding this comment.
2.9.2 would be ever so slightly better -- there was some breaking in 2.9.0-flat related to types_or
There was a problem hiding this comment.
Thanks for reviewing and suggesting this. Updated in #1895.
noxan
pushed a commit
to noxan/black
that referenced
this pull request
Jun 6, 2021
Since pre-commit 2.9.0 (2020-11-21), the types_or key can be used to match multiple disparate file types. For more upstream details, see: pre-commit/pre-commit#607 Add the minimum_pre_commit_version to require pre-commit 2.9.0+. Fixes psf#402
MarcoGorelli
added a commit
to MarcoGorelli/isort
that referenced
this pull request
Jul 28, 2021
The PR which led to 2.9.0 was made by a data scientist and so it contains a bug in the default types for `types_or`, it'd be better to have 2.9.2 as the minimum version - at least, that's what Anthony Sottile suggested be done in `black` psf/black#1875 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since pre-commit 2.9.0 (2020-11-21), the types_or key can be used to
match multiple disparate file types. For more upstream details, see:
pre-commit/pre-commit#607
Fixes #402