Fix for "# fmt: on" with decorators #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's merge this. I'll need:
|
autophagy
approved these changes
May 8, 2020
autophagy
added a commit
that referenced
this pull request
May 8, 2020
Follow up from #1325 Adds docstrings to the fmt checking functions. Renames fmt_on to is_fmt_on. Adds the functions to the autodocs.
autophagy
added a commit
that referenced
this pull request
May 8, 2020
Follow up from #1325 Adds docstrings to the fmt checking functions. Renames fmt_on to is_fmt_on. Adds the functions to the autodocs.
autophagy
added a commit
that referenced
this pull request
May 8, 2020
Follow up from #1325 Adds docstrings to the fmt checking functions. Renames fmt_on to is_fmt_on. Adds the functions to the autodocs.
autophagy
added a commit
that referenced
this pull request
May 8, 2020
Follow up from #1325 Adds docstrings to the fmt checking functions. Renames fmt_on to is_fmt_on. Adds the functions to the autodocs.
autophagy
added a commit
that referenced
this pull request
May 8, 2020
Follow up from #1325 Adds docstrings to the fmt checking functions. Renames fmt_on to is_fmt_on. Adds the functions to the autodocs.
|
Thanks a lot! #560 can be closed now I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-submitting #1324 using correct email.
This is quick and likely dirty fix for #560. It is based on assumption that indentation has semantic meaning in Python so in case if
# fmt: onexists in node children at the same column as opening# fmt: offwe should process each child separately excluding only those before# fmt: on.This seems to work for my use case which is blocking black adoption in my team and doesn't break any tests but it would be great if someone with more experience in codebase could help to polish it because I dived into black source code only two hours ago.
Thanks!