Add support for all valid string literals #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 181
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 181
💛 - Coveralls |
Pull Request Test Coverage Report for Build 191
💛 - Coveralls |
ambv
requested changes
Apr 9, 2018
blib2to3/pgen2/tokenize.py
Outdated
|
|
||
| _strprefixes = set(combinations('r', 'R', 'f', 'F') + | ||
| combinations('r', 'R', 'b', 'B') + | ||
| ['u', 'U']) |
There was a problem hiding this comment.
You're missing 'uR', 'UR', 'Ur', 'ur' which is valid on Python 2.
There was a problem hiding this comment.
uR right 🤣 I was wondering why tokenize used to accept this in the regex above.
There was a problem hiding this comment.
Funnily enough, since we are still supporting u"" in Python 3, not supporting ur"" is likely just an omission of whoever brought u"" back :-)
ambv
approved these changes
Apr 9, 2018
zsol
commented
Apr 9, 2018
blib2to3/pgen2/tokenize.py
Outdated
| return [(x + y).strip() for x in l for y in l + (" ",) if x.casefold() != y.casefold()] | ||
| def _combinations(*l): | ||
| return set( | ||
| x + y for x in l for y in l + ("",) if x.casefold() != y.casefold() |
There was a problem hiding this comment.
That needs to be a (" ",) in the middle
|
Thanks! ✨ 🍰 ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3. This was the cause for black not being able to support
rfstrings. Now this forked version oflib2to3only parses valid string literals as defined by https://docs.python.org/3/reference/lexical_analysis.html#string-and-bytes-literals