Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unstable formatting with some # type: ignores #1113

Merged
merged 1 commit into from Nov 25, 2019

Commits on Oct 29, 2019

  1. Fix unstable formatting with some # type: ignores

    `type: ignore` shouldn't block collapsing a line, since it will still
    apply fine to the merged line. This prevents an issue where a reformat
    causes it to shift lines and then be merged on a subsequent pass.
    
    There is a downside to this, which is that it can cause a `type:
    ignore` to apply to more code than was originally intended. There
    might be a way to apply this in a more limited situation, but I'm not
    sure what it is.
    
    Fixes psf#1061.
    msullivan committed Oct 29, 2019
    Copy the full SHA
    6c44595 View commit details
    Browse the repository at this point in the history