Run pre-commit on Travis CI #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Oct 20, 2019
| entry: mypy | ||
| types: [python] | ||
| exclude: ^docs/conf.py | ||
| - id: black |
There was a problem hiding this comment.
at least for black, I believe the intention was to dogfood black itself -- the others I agree 👍
There was a problem hiding this comment.
We also have unit tests that run Black on itself, so this check would likely conflict with those tests if a PR changes formatting.
There was a problem hiding this comment.
I think the version pre-commit installs is only available for pre-commit, so wouldn't affect those unit tests.
Anyway, I've reverted this bit so Black dogfoods for pre-commit as well.
asottile
reviewed
Oct 20, 2019
|
Thank you for this, it will make our tests tighter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#874 (comment) notes pre-commit is needed on the CI.
This adds a new lint job to run pre-commit.
Also, instead of running local versions of the lint tools, which need installing explicitly on Travis, use pinned repo versions and let pre-commit install them.
This is the standard way of running pre-commit. @asottile wrote in #1073 (comment):
Finally, since pre-commit is also running Black, mypy and Flake8 in a single job, we no longer need them as separate jobs and can reduce the number from 6 to 4 (and Travis gives 5 parallel).