Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tell users to use -t py310 #2668

Merged
merged 2 commits into from Dec 4, 2021
Merged

tell users to use -t py310 #2668

merged 2 commits into from Dec 4, 2021

Conversation

JelleZijlstra
Copy link
Collaborator

No description provided.

@isidentical
Copy link
Collaborator

This is very cool! Just one question, I know it doesn't sound really good but considering the algorithm is still experimental, would it make sense to run driver.parse_string() on a separate thread with a fixed timeout (idk, .join(timeout=3)?) (in case it gets really really slow, unlikely but still, a nice precaution)?

Copy link
Collaborator

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, thanks!

We could run it under a time restricted thread but that will be a bit more complicated as 3.6 doesn't require systems to have a functional multithreading implementation. Not sure how much it'd be worth.

@JelleZijlstra JelleZijlstra merged commit dc8cdda into main Dec 4, 2021
@JelleZijlstra JelleZijlstra deleted the usetpy310 branch December 4, 2021 23:30
@JelleZijlstra
Copy link
Collaborator Author

@isidentical thanks! We discussed on Discord and decided to skip the extra timeout to avoid extra complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants