Fix line generation for match match: / case case:
#2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isidentical
commented
Nov 30, 2021
| """Visit either a match or case statement.""" | ||
| normalize_invisible_parens(node, parens_after=set()) | ||
|
|
||
| yield from self.line() |
There was a problem hiding this comment.
I am not sure if this is the correct solution; it originates from the assumptions that for each match_statement/case_statement node, there will be only one valid match/case keyword for the context. So we simply yield a line; and for all following encounters of child nodes, we process them as usual.
JelleZijlstra
approved these changes
Nov 30, 2021
isidentical
commented
Nov 30, 2021
| case func(match, case): | ||
| ... | ||
| case another: |
There was a problem hiding this comment.
I've fixed some syntax errors in this file (e.g a name pattern can't be followed by anything else) to ensure everything is also parsable by the python parser.
|
@JelleZijlstra that was fast 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2660