Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to split lines that start with a string operator #2286

Merged
merged 5 commits into from May 30, 2021
Merged

Make sure to split lines that start with a string operator #2286

merged 5 commits into from May 30, 2021

Conversation

bbugyi200
Copy link
Contributor

Fixes #2284

@bbugyi200 bbugyi200 mentioned this pull request May 30, 2021
Open
@ambv ambv merged commit 4ca4407 into psf:main May 30, 2021
bbugyi200 added a commit to bbugyi200/black that referenced this pull request May 31, 2021
@bbugyi200
Correct max string length calculation after psf#2286
e120f45 
PR psf#2286 did not fix the edge-cases (e.g. when the string is just long
enough to cause a line to be 89 characters long). This PR corrects that
mistake.
@bbugyi200 bbugyi200 mentioned this pull request May 31, 2021
Merged
@Jackenmen Jackenmen mentioned this pull request May 31, 2021
Closed
JelleZijlstra pushed a commit that referenced this pull request Jun 1, 2021
@bbugyi200
Correct max string length calculation when there are string operators (…
a4e35b3 
…#2292)

PR #2286 did not fix the edge-cases (e.g. when the string is just long
enough to cause a line to be 89 characters long). This PR corrects that
mistake.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The --experimental-string-processing flag does not split long strings that start with ==
3 participants
@bbugyi200 @JelleZijlstra @ambv