New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String processing produces code exceeding length limit #2294
Labels
F: linetoolong
Black makes our lines too long
F: strings
Related to our handling of strings
T: bug
Something isn't working
Comments
Probably what's also important here is that Black doesn't try to split this string despite it being too long: class X:
async def foo(self):
msg = ""
for candidate in CANDIDATES:
msg += "**{candidate.object_type} {candidate.rev}** - {candidate.description}\n" After a second look, it appears that usage of |
Does #2292 fix this? |
Never mind, you already discussed it. |
This issue should be fixed by the following PR: #2312 |
JelleZijlstra
pushed a commit
that referenced
this issue
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
F: linetoolong
Black makes our lines too long
F: strings
Related to our handling of strings
T: bug
Something isn't working
Describe the bug
String processing produces code exceeding the length limit when it was already formatted properly before.
To Reproduce
For example:
--experimental-string-processing
Expected behavior
I expected the code to remain unchanged.
Environment (please complete the following information):
cf75673
at the time of testing)Does this bug also happen on main?
Yes.
Additional context
I was unable to find another issue that would seem to be the same as this though it's possible I missed something. Just to be sure it's not about the same thing #2284 is, I also tried out the changes from #2292 (since they apparently fix some edge cases that weren't fixed by #2286.
Also, the original code actually contained f-string but to rule out that it has anything to do with #2293, I changed it to use regular strings which as you can see from the issue description didn't change the end result.
The text was updated successfully, but these errors were encountered: