Possible fix for issue with indentation and fmt: skip #2281
Conversation
enzet
changed the title
|
Hey, I just want to let you know that we should be able to get started on the review process for your changeset soon. Apologies for the wait. Your fix looks promising, but I'm bad when it comes to AST mangling code so take my opinion with a grain of salt :) Looking forward to reviewing your work, thanks for working on this! |
Not sure the fix is right. Here is what I found: issue is connected
with line
first.prefix = prefix[comment.consumed :]
in `comments.py`. `first.prefix` is a prefix of the line, that ends
with `# fmt: skip`, but `comment.consumed` is the length of the
`" # fmt: skip"` string. If prefix length is greater than 14,
`first.prefix` will grow every time we apply formatting.
Test for fmt: skip comment when indentation needs more than 14 spaces.
There was a problem hiding this comment.
I'm in roughly the same boat as Jelle, but I did spent a few hours somewhat recently in this specific part of the codebase trying to fix a bug (I wasn't successful) and this looks good to me as well.
Thank you for the PR! It's awesome to see one more bug fixed. This project is only possible by contributions like these 🖤. You're awesome, @enzet! Perhaps we should have done some more testing before rolling out this new feature 😅. Anyway, it would be even more awesome if you could provide some feedback on your experience contributing to psf/black. No pressure to do so, but it would be helpful. More details here: #2238. Thanks again.
|
Thank you, @ichard26! Hope the fix is helpful. |
Possible fix for #2254
Not sure the fix is right. Here is what I found: the issue is connected with the line
in
comments.py.first.prefixis a prefix of the line, that ends with# fmt: skip, butcomment.consumedis the length of the" # fmt: skip"string. If prefix length is greater than 14,first.prefixwill grow every time we apply formatting.