Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL ERROR: Black produced different code on the second pass of the formatter #1702

Closed
calebsander opened this issue Sep 13, 2020 · 1 comment
Labels
C: unstable formatting Formatting changed on the second pass R: duplicate This issue or pull request already exists T: bug Something isn't working

Comments

@calebsander
Copy link

calebsander commented Sep 13, 2020

Describe the bug
See title. Black requested that I open an issue.

To Reproduce
Try to format the following file (black test.py):

def test_search(client):
    assert set(execute_search(
        email="",
        username="",
        name=None,
        house_id=None,
        building_id=None,
        grad_year=None
    )) == set([])

This is a minimized excerpt from a larger yapf-formatted file.

Expected behavior
Successful formatting, as this is valid Python code.

Environment (please complete the following information):

  • Version: 20.8b1
  • OS and Python version: macOS 11.0, Python 3.8.2

Does this bug also happen on master? Yes

Additional context

Black's log file:

Mode(target_versions=set(), line_length=88, string_normalization=True, experimental_string_processing=False, is_pyi=False)
--- source
+++ first pass
@@ -1,9 +1,11 @@
 def test_search(client):
-    assert set(execute_search(
-        email="",
-        username="",
-        name=None,
-        house_id=None,
-        building_id=None,
-        grad_year=None
-    )) == set([])
+    assert set(
+        execute_search(
+            email="",
+            username="",
+            name=None,
+            house_id=None,
+            building_id=None,
+            grad_year=None,
+        )
+    ) == set([])
--- first pass
+++ second pass
@@ -1,11 +1,14 @@
 def test_search(client):
-    assert set(
-        execute_search(
-            email="",
-            username="",
-            name=None,
-            house_id=None,
-            building_id=None,
-            grad_year=None,
+    assert (
+        set(
+            execute_search(
+                email="",
+                username="",
+                name=None,
+                house_id=None,
+                building_id=None,
+                grad_year=None,
+            )
         )
-    ) == set([])
+        == set([])
+    )
@calebsander calebsander added the T: bug Something isn't working label Sep 13, 2020
@ichard26 ichard26 added the C: unstable formatting Formatting changed on the second pass label Sep 13, 2020
@ichard26 ichard26 added the R: duplicate This issue or pull request already exists label Apr 25, 2021
@ichard26
Copy link
Collaborator

Hello!

All reproduction cases in this issue format without error on master. The fixing commit was 8672af3 from PR GH-2126. I'll be marking this issue as a duplicate of GH-1629 since that's what GH-2126 aimed to fix and it's highly likely this issue falls under GH-1629.

Since we use the issue tracker as a reflection of what's on master, I'll be closing this issue. If you have any issues, especially with the new (but stable) output, please open a new issue. Oh and the fix should be available in a published release soon, see GH-2125 for more info.

Thank you for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: unstable formatting Formatting changed on the second pass R: duplicate This issue or pull request already exists T: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants