Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More unstable formatting #1704

Closed
plammens opened this issue Sep 14, 2020 · 2 comments
Closed

More unstable formatting #1704

plammens opened this issue Sep 14, 2020 · 2 comments
Labels
C: unstable formatting Formatting changed on the second pass T: bug Something isn't working

Comments

@plammens
Copy link

plammens commented Sep 14, 2020

I think this one is different from #1629 . See the log (stripped down):

--- source
+++ first pass
@@ -314,12 +330,15 @@
     """
     clients = []
 
     async def go(__param, *args, server_kwargs=None, **kwargs):  # type: ignore
 
-        if (isinstance(__param, Callable) and  # type: ignore
-                not isinstance(__param, (Application, BaseTestServer))):
+        if isinstance(
+            __param, Callable
+        ) and not isinstance(  # type: ignore
+            __param, (Application, BaseTestServer)
+        ):
             __param = __param(loop, *args, **kwargs)
             kwargs = {}
         else:
             assert not args, "args should be empty"

--- first pass
+++ second pass
@@ -330,13 +330,11 @@
     """
     clients = []
 
     async def go(__param, *args, server_kwargs=None, **kwargs):  # type: ignore
 
-        if isinstance(
-            __param, Callable
-        ) and not isinstance(  # type: ignore
+        if isinstance(__param, Callable) and not isinstance(  # type: ignore
             __param, (Application, BaseTestServer)
         ):
             __param = __param(loop, *args, **kwargs)
             kwargs = {}
         else:
@plammens plammens added the T: bug Something isn't working label Sep 14, 2020
@Holzhaus
Copy link

Yes, I sometimes get this too when running black locally vs running black on CI. Same black version (using the pre-commit framework).

@ichard26 ichard26 added the C: unstable formatting Formatting changed on the second pass label Oct 18, 2020
@ichard26
Copy link
Collaborator

Hello!

All of the reproduction cases reported in this issue format without error using the latest release (20.8b1). For that reason, I'll be closing this issue. If you have any other issues, especially with the (now stable) output, please open a new issue.

Thank you for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: unstable formatting Formatting changed on the second pass T: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants