Skip to content

Commit

Permalink
[primer] Enable everything (#2288)
Browse files Browse the repository at this point in the history
See if we pass all our repos with experimental string processing enabled.
Django probably needed:
- Ignores >= 3.8 only

We could support PEP440 version specifiers, but that would introduce the packaging module as a dependency that I'd like to avoid ... Or I could implement a poor persons version or vendor

Commit history before merge:
 * [primer] Enable everything
 * Add exclude extend to django CLI args for primer
 * Change default timeout to from 5 to 10 mins for a primer project
 * Skip string normalization for Django
 * Limit Django to >= 3.8 due to := operator
  • Loading branch information
cooperlees committed Jun 7, 2021
1 parent 99b68e5 commit c1c2418
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/black_primer/lib.py
Expand Up @@ -39,7 +39,7 @@ class Results(NamedTuple):

async def _gen_check_output(
cmd: Sequence[str],
timeout: float = 300,
timeout: float = 600,
env: Optional[Dict[str, str]] = None,
cwd: Optional[Path] = None,
) -> Tuple[bytes, bytes]:
Expand Down
13 changes: 7 additions & 6 deletions src/black_primer/primer.json
Expand Up @@ -30,13 +30,16 @@
"py_versions": ["all"]
},
"django": {
"disabled_reason": "black --check --diff returned 123 on tests_syntax_error.py",
"disabled": true,
"cli_arguments": ["--experimental-string-processing"],
"cli_arguments": [
"--experimental-string-processing",
"--skip-string-normalization",
"--extend-exclude",
"/((docs|scripts)/|django/forms/models.py|tests/gis_tests/test_spatialrefsys.py|tests/test_runner_apps/tagged/tests_syntax_error.py)"
],
"expect_formatting_changes": true,
"git_clone_url": "https://github.com/django/django.git",
"long_checkout": false,
"py_versions": ["all"]
"py_versions": ["3.8", "3.9"]
},
"flake8-bugbear": {
"cli_arguments": ["--experimental-string-processing"],
Expand All @@ -53,8 +56,6 @@
"py_versions": ["all"]
},
"pandas": {
"disabled_reason": "black-primer runs failing on Pandas - #2193",
"disabled": true,
"cli_arguments": ["--experimental-string-processing"],
"expect_formatting_changes": true,
"git_clone_url": "https://github.com/pandas-dev/pandas.git",
Expand Down

0 comments on commit c1c2418

Please sign in to comment.