Skip to content

Commit

Permalink
Mention comment non-processing in documentation (#2306)
Browse files Browse the repository at this point in the history
This commit adds a short section discussing the non-processing of docstrings
besides spacing improvements, mentions comment moving and links to the
AST equivalence discussion. I also added a simple spacing test for good
measure.

Commit history before merge:

* Mention comment non-processing in documentation, add spacing test
* Mention special cases for comment spacing
* Add all special cases, improve wording
  • Loading branch information
felix-hilden committed Jun 8, 2021
1 parent 40fae18 commit a9eab85
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
10 changes: 10 additions & 0 deletions docs/the_black_code_style/current_style.md
Expand Up @@ -200,6 +200,16 @@ following field or method. This conforms to
_Black_ won't insert empty lines after function docstrings unless that empty line is
required due to an inner function starting immediately after.

### Comments

_Black_ does not format comment contents, but it enforces two spaces between code and a
comment on the same line, and a space before the comment text begins. Some types of
comments that require specific spacing rules are respected: doc comments (`#: comment`),
section comments with long runs of hashes, and Spyder cells. Non-breaking spaces after
hashes are also preserved. Comments may sometimes be moved because of formatting
changes, which can break tools that assign special meaning to them. See
[AST before and after formatting](#ast-before-and-after-formatting) for more discussion.

### Trailing commas

_Black_ will add trailing commas to expressions that are split by comma where each
Expand Down
4 changes: 2 additions & 2 deletions tests/data/comments2.py
Expand Up @@ -159,7 +159,7 @@ def _init_host(self, parsed) -> None:
#######################


instruction()
instruction()#comment with bad spacing

# END COMMENTS
# MORE END COMMENTS
Expand Down Expand Up @@ -336,7 +336,7 @@ def _init_host(self, parsed) -> None:
#######################


instruction()
instruction() # comment with bad spacing

# END COMMENTS
# MORE END COMMENTS

0 comments on commit a9eab85

Please sign in to comment.