Skip to content

Commit

Permalink
Pin setuptools-scm build time dependency (#2457)
Browse files Browse the repository at this point in the history
The setuptools-scm dependency in setup.cfg did not have a version
specified, leading to the issues described in #2449 after a faulty release
of setuptools-scm was published. To avoid this issue in the future, the
last version before that faulty update is now pinned.

Commit history before merge:

* Pin setuptools-scm dependency version (#2449)
* Update CHANGES.md
* Let's pin in pyproject.toml too

Mostly since it's non-build-backend specific configuration and more
widely standardized file. Not sure what benefits pinning in setup.cfg
gives us on top of pyproject.toml but I'd rather not find out during
the release that is supposed to happen today 😉

Co-authored-by: FiNs <24248249+FabianNiehaus@users.noreply.github.com>
  • Loading branch information
ichard26 and FabianNiehaus committed Aug 28, 2021
1 parent 7a093f0 commit a5bb6e0
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGES.md
Expand Up @@ -13,6 +13,7 @@
trailing comma (#2384)
- Parsing support has been added for unparenthesized walruses in set literals, set
comprehensions, and indices (#2447).
- Pin `setuptools-scm` build-time dependency version (#2457)

### _Blackd_

Expand Down
5 changes: 4 additions & 1 deletion pyproject.toml
Expand Up @@ -23,7 +23,10 @@ extend-exclude = '''
# NOTE: You don't need this in your own Black configuration.

[build-system]
requires = ["setuptools>=41.0", "setuptools-scm", "wheel"]
# We're pinning setuptools-scm to bugfix versions only because for build-time
# deps having them work on install by default is really important. Especially
# since it's hard for users to work-around the specified build requirements.
requires = ["setuptools>=41.0", "setuptools_scm~=6.0.1", "wheel"]
build-backend = "setuptools.build_meta"

[tool.pytest.ini_options]
Expand Down
3 changes: 2 additions & 1 deletion setup.cfg
@@ -1,2 +1,3 @@
[options]
setup_requires = setuptools_scm
setup_requires =
setuptools_scm~=6.0.1

0 comments on commit a5bb6e0

Please sign in to comment.