Skip to content

Commit

Permalink
fix: run pypi / docker upload from published draft releases (#2461)
Browse files Browse the repository at this point in the history
Draft releases don't trigger the workflows (that's good!) but since they only 

Commit history before merge:

* fix: run pypi upload from published draft releases
* Fix broken task list markup in PR template
* change docker workflow to build on release publish

Co-authored-by: Richard Si <63936253+ichard26@users.noreply.github.com>
  • Loading branch information
onerandomusername and ichard26 committed Aug 30, 2021
1 parent a8b4665 commit 79575f3
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Expand Up @@ -18,9 +18,9 @@
Tests are required for bugfixes and new features. Documentation changes
are necessary for formatting and most enhancement changes. -->

- [] Add a CHANGELOG entry if necessary?
- [] Add / update tests if necessary?
- [] Add new / update outdated documentation?
- [ ] Add a CHANGELOG entry if necessary?
- [ ] Add / update tests if necessary?
- [ ] Add new / update outdated documentation?

<!-- Just as a reminder, everyone in all psf/black spaces including PRs
must follow the PSF Code of Conduct (link below).
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker.yml
Expand Up @@ -5,7 +5,7 @@ on:
branches:
- "main"
release:
types: created
types: [published]

jobs:
docker:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pypi_upload.yml
Expand Up @@ -2,7 +2,7 @@ name: pypi_upload

on:
release:
types: created
types: [published]

jobs:
build:
Expand Down

0 comments on commit 79575f3

Please sign in to comment.