Save Hypothesis buffer to database #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One quick Q: is 6.0.0 the right minimum version given the shenanigans we're pulling? I bail out if hypothesis is requested, and the version is too old: Line 83 in 5f797f6 Oh, and add yourself to contributors if you'd like! https://github.com/pschanely/CrossHair/blob/main/doc/source/contributing.rst |
|
Yep, 6.0 is a reasonable lower bound - the specific internals we're using go back a fair bit further, but you'd start to run into other interoperability problems and I'd rather not encourage that. Hypothesis explicitly only supports our most recent release! Probably also worth noting this as progress on #45! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seamless handoff between symbolic and concrete tooling 馃ぉ