Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electra: Properly Calculate Proposer Probabilities for MaxEB #14010

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Electra: Properly Calculate Proposer Probabilities for MaxEB #14010

wants to merge 3 commits into from

Conversation

james-prysm
Copy link
Contributor

@james-prysm james-prysm commented May 16, 2024 •
edited

What type of PR is this?

Feature

What does this PR do? Why is it needed?

spec change around max EB ( EIP7251)

consolidated validators should have different proposal probability as non-consolidated validators

Which issues(s) does this PR fix?

ethereum/consensus-specs#3769

Other notes for review

@james-prysm james-prysm added the Electra electra hardfork label May 16, 2024
@james-prysm james-prysm requested a review from a team as a code owner May 16, 2024 15:14
@james-prysm james-prysm added the Blocked Blocked by research or external factors label May 16, 2024
prestonvanloon
prestonvanloon approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will have to wait for new spectests to be issued. Otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@nalepae nalepae Awaiting requested review from nalepae nalepae is a code owner automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Blocked Blocked by research or external factors Electra electra hardfork
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@james-prysm @prestonvanloon