Set Custody Count Correctly #14004
Merged
Set Custody Count Correctly #14004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
requested review from
kasey,
nalepae and
rauljordan
and removed request for
a team
nalepae
approved these changes
May 15, 2024
saolyn
reviewed
May 15, 2024
Comment on lines
63
to
64
| // Load the `custody_subnet_count` | ||
| // TODO: Do not harcode `custody_subnet_count` |
There was a problem hiding this comment.
With these latest changes, are these comments still relevant?
nisdas
added a commit
that referenced
this pull request
May 16, 2024
* Set Custody Count Correctly * Fix Discovery Count
nalepae
pushed a commit
that referenced
this pull request
May 30, 2024
* Set Custody Count Correctly * Fix Discovery Count
nalepae
pushed a commit
that referenced
this pull request
May 30, 2024
* Set Custody Count Correctly * Fix Discovery Count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
We marshal the custody count correctly as an 8-byte slice instead of 1.
Which issues(s) does this PR fix?
N.A
Other notes for review