Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Replace a Few IntFlags with Uint64Flags (#9959)" #10163

Merged
merged 3 commits into from
Feb 1, 2022

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Feb 1, 2022

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

This reverts commit 790bf03.

urfave is unable to read uint64 values from a yaml and is unlikely to ever support them anytime soon.

urfave/cli#599
urfave/cli#833

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas added the Ready For Review A pull request ready for code review label Feb 1, 2022
@nisdas nisdas requested a review from a team as a code owner February 1, 2022 04:45
rauljordan
rauljordan previously approved these changes Feb 1, 2022
@prylabs-bulldozer prylabs-bulldozer bot merged commit e83c9d5 into develop Feb 1, 2022
hmrtn added a commit to hmrtn/prysm that referenced this pull request Feb 9, 2022
hmrtn added a commit to hmrtn/prysm that referenced this pull request Feb 9, 2022
@nisdas nisdas deleted the revertFlags branch April 15, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants