Remove deprecated Prompt proc configuration. #2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrehjr
force-pushed
the
remove-deprecated-prompt-config
branch
from
9617813
to
ae8a359
Compare
andrehjr
force-pushed
the
remove-deprecated-prompt-config
branch
from
ae8a359
to
57b077e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proc/prompt was deprecated on v0.13.0 long time ago.. on #1877 We should move towards using the Pry::Prompt API instead. It's also nice to remove some older code in here.
Some projects already made their move to remove the older prompt warnings. So I think this won't be an issue.
This also removes one type of usage do OpenStruct, which will not be loaded by Ruby 3.5.0.