Remove OpenStruct usage from Pry::CommandState #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrehjr
force-pushed
the
remove-ostruct-command-state
branch
from
c98f243
to
d8e41fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works towards removing OpenStruct usage. As ostruct will no longer be part of the default gems after Ruby 3.5.
I am still on the fence about using command_options state to define the attributes for the Struct for each Command. Or, changing CommandState back to a Hash instead. I've checked a few plugins to see if anyone outside pry is using state directly.. But I couldn't find any.
To reduce the amount of changes and keep compatibility with other Pry Commands on this PR, I've tried to keep changes to a minimum and went with the Struct approach, and may refactor again later on.
ruby-head is still faling, as there are more OpenStruct references on the code.