Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repair ExceptionHandler#exception_text for Ruby 3.2 #2285

Merged
merged 5 commits into from Sep 3, 2023
Merged

repair ExceptionHandler#exception_text for Ruby 3.2 #2285

merged 5 commits into from Sep 3, 2023

Conversation

hyuraku
Copy link
Contributor

@hyuraku hyuraku commented Aug 30, 2023

closes #2280

@andrehjr
Copy link
Member

Hi 🙌 thanks for the PR!

The following specs broke on ruby 3.2 and ruby-head, can you take a look?

rspec ./spec/exception_handler_spec.rb:26 # Pry::ExceptionHandler.handle_exception when exception is a standard error prints standard error message
rspec ./spec/exception_handler_spec.rb:55 # Pry::ExceptionHandler.handle_exception when exception is a nested standard error prints standard error message

@hyuraku hyuraku force-pushed the repair-exception_text-for-Ruby3.2 branch from 16a4ccd to 3d2e1b3 Compare August 30, 2023 13:49
@hyuraku hyuraku force-pushed the repair-exception_text-for-Ruby3.2 branch from 54167de to 1d59aa0 Compare August 31, 2023 10:51
@hyuraku hyuraku force-pushed the repair-exception_text-for-Ruby3.2 branch from 5b02359 to 3b106f1 Compare September 1, 2023 13:18
@hyuraku
Copy link
Contributor Author

hyuraku commented Sep 1, 2023

@andrehjr
I solved two specs you said #2285 (comment).
But only three specs still broke in ls_spec.rb on ruby-head.

andrehjr
andrehjr approved these changes Sep 3, 2023
View reviewed changes
Copy link
Member

@andrehjr andrehjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. the ls_spec errors are not related, so it's fine to merge as is.

calling detailed_message is the correct way for Ruby 3.2 as stated on https://github.com/ruby/ruby/blob/3602e253e79b796661168b458e22ba1694ec06e5/doc/NEWS/NEWS-3.2.0.md?plain=1#L202-L206

@andrehjr andrehjr merged commit 5a7293f into pry:master Sep 3, 2023
18 of 19 checks passed
@andrehjr andrehjr mentioned this pull request Sep 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrehjr andrehjr andrehjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Did you mean" output no longer shown with Ruby 3.2
2 participants
@hyuraku @andrehjr