Make method_size_cutoff configurable #2230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT & WHY
The purpose of this PR is to enable
method_size_cutoffto be configured throughPry.config.method_size_cutoff.Currently,
method_size_cutoffis fixed to 30, but it might be useful that users can control the cutoff size.Checked
pry_instance.config.method_size_cutoffis configured by addingPry.config.method_size_cutoff = {integer}to.pryrc, and whereami works as expected.Usage of
method_size_cutoffis limited in pry/pry repository among pry/* repositories.The variable can be accessed from outside of the class by
Pry::Command::Whereami.method_size_cutoff, but that does not happen in at least 16 repositories of pry organization.What do you think about it?馃