Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2141 fix Kernel.system() exit status #2226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

h7kayama
Copy link
Contributor

@h7kayama h7kayama commented Nov 26, 2021

This PR fixes #2141

The child process was different because which #{pager_executable} was execute on the first run.

Before

⋊> ~/g/g/h/pry on master ◦ bundle exec pry
[1] pry(main)> $?
=> #<Process::Status: pid 24738 exit 0>
[2] pry(main)> $?
=> #<Process::Status: pid 24778 exit 0>
[3] pry(main)> $?
=> #<Process::Status: pid 24778 exit 0>

I thought it would be better to execute which #{pager_executable} at the time of initialize.

After

⋊> ~/g/g/h/pry on fix_child_process  bundle exec pry
[1] pry(main)> $?
=> #<Process::Status: pid 24214 exit 0>
[2] pry(main)> $?
=> #<Process::Status: pid 24214 exit 0>
[3] pry(main)> $?
=> #<Process::Status: pid 24214 exit 0>
[4] pry(main)>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kernel.system() exit status doesn't seem to be stored at $?
1 participant