Fixed ^A/^B and added support for Windows ConPty.
#2209
Conversation
SilverPhoenix99
force-pushed
the
2185-pager-bug-fix
branch
from
412436b
to
f891dfb
Compare
SilverPhoenix99
changed the title
\001/\002 escape sequences optional.^A/^B and added support for Windows ConPty.
…ry.config.escape_headers`.
Fixed unit tests to also work on Windows.
…s on prompts only.
SilverPhoenix99
force-pushed
the
2185-pager-bug-fix
branch
from
0c00c26
to
6dc1f09
Compare
Fixed escape codes for Windows, when Ansi is available.
| Added `Pry.config.escape_prompt` to manage adding those control characters to the prompt (the default is `true`). | ||
| It can then be disabled for terminals that don't have readline, or where readline's version doesn't support those characters. | ||
| \ | ||
| Added support for [ConPty](https://devblogs.microsoft.com/commandline/windows-command-line-introducing-the-windows-pseudo-console-conpty/) |
There was a problem hiding this comment.
For what it's worth, ConPTY is not the name we use for the version of the console that supports VT/control sequences.
ENABLE_VIRTUAL_TERMINAL_PROCESSING enables VT sequences on a fairly old version of Windows 10 -- something like "10.0.10240". That's the only thing you'll need to check. 😄
ConPTY is a newer API that lets somebody else display the UI for the console, instead of leaving us to do it. That's how somebody like alacritty or hyper can run pry! It is much newer (Windows 10 version 17763 or higher.)
Fortunately, you only need the first thing.
There was a problem hiding this comment.
(Happy to answer any questions about it! I'm the engineering lead for the console and Windows Terminal. 👋)
|
@kyrylo @SilverPhoenix99 This has been open for a month now and it looks good... could we get it merged please? 😄 |
|
Pretty please? |
|
Bumping for visibility, it's been another month and I'd like to see this get added. |
|
Is there a blocker to getting this merged? |
|
@Ikariusrb I don't think so, it's on my list to properly review this. And to also configure Windows tests to Github Actions to ensure it keeps working. @kyrylo any thoughts over here? |
Fixed issue with printing control characters
\001/^Aand\002/^B.Added
Pry.config.escape_promptto manage adding those control characters to the prompt (the default istrue).It can then be disabled for terminals that don't have readline, or where readline's version doesn't support those characters.
Added support for ConPty in Windows, which supports Ansi escapes natively.
Fixed all unit tests to run in Windows.