Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--no-color option make Pry produce input echo #2166

Closed
stoyanovskiy239 opened this issue Dec 4, 2020 · 3 comments
Closed

--no-color option make Pry produce input echo #2166

stoyanovskiy239 opened this issue Dec 4, 2020 · 3 comments

Comments

@stoyanovskiy239
Copy link

Hi!
I would expect this option to only affect syntax highlighting presence and not IO behaviour.
Checked this with Ruby 2.5.7, 2.7.2, and JRuby 9.2.13 in bash on macOS Catalina.
Here's a screenshot with 2.5.7:
image

@barrettkingram
Copy link
Contributor

For what it's worth, I'm unable to reproduce this:

bingram:~/Projects/pry (master)$ ruby -v
ruby 2.5.7p206 (2019-10-01 revision 67816) [x86_64-darwin16]
bingram:~/Projects/pry (master)$ pry -v
Pry version 0.13.1 on Ruby 2.5.7
bingram:~/Projects/pry (master)$ pry --no-color
[1] pry(main)> "Echo"
=> "Echo"

Any chance something in your pryrc could be affecting this?

@xjunior
Copy link
Contributor

xjunior commented Mar 26, 2021

Could it be caused by #2167 ?

@andrehjr
Copy link
Member

andrehjr commented Mar 7, 2022

Also unable to reproduce this.

~ » pry --no-color                            
[1] pry(main)> "No echo"
=> "No echo"
[2] pry(main)> 2 + 2
=> 4
~ » ruby -v 
ruby 3.0.3p157 (2021-11-24 revision 3fb7d2cadc) [x86_64-darwin21]
~ » pry --version
Pry version 0.14.1 on Ruby 3.0.3

Also tested with jruby 9.3.3.0 (2.6.8) 2022-01-19 b26de1f5c5 Java HotSpot(TM) 64-Bit Server VM 17.0.2+8-LTS-86 on 17.0.2+8-LTS-86 +jit [darwin-x86_64].

@andrehjr andrehjr closed this as completed Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants