Skip to content

Commit

Permalink
Merged v0.46.2 into release-pio/v0.46.x.
Browse files Browse the repository at this point in the history
Squashed commit of the following:

commit 26786a0
Author: Julien Robert <julien@rbrt.fr>
Date:   Mon Oct 3 18:13:53 2022 +0200

    chore: prepare `v0.46.2` release (cosmos#13436)

commit 72a904d
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Fri Sep 30 18:16:51 2022 -0400

    fix: add close for grpcOnly mode (backport cosmos#13418) (cosmos#13422)

commit f80e883
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Sep 29 08:10:41 2022 -0500

    fix: add gRPC nil/zero check in query (backport cosmos#13352) (cosmos#13417)

    * fix: add gRPC nil/zero check in query (cosmos#13352)

    (cherry picked from commit a9f02d9)

    # Conflicts:
    #	CHANGELOG.md
    #	codec/proto_codec_test.go

    * fix conflicts

    * fix conflicts

    Co-authored-by: yihuang <huang@crypto.com>

commit 51c8a1a
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Tue Sep 27 07:48:21 2022 -0500

    feat: Add notice for possible iavl fast node migration (backport cosmos#13390) (cosmos#13398)

    * add notice for possible iavl fast node migration (cosmos#13390)

    (cherry picked from commit b609105)

    * Update baseapp/baseapp.go

    Co-authored-by: adu-crypto <94821467+adu-crypto@users.noreply.github.com>
    Co-authored-by: Julien Robert <julien@rbrt.fr>

commit 95948f6
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Fri Sep 23 14:26:27 2022 -0500

    perf: reduce user's password prompts when calling keyring List function (backport cosmos#13207) (cosmos#13368)

    * perf: reduce user's password prompts when calling keyring List function (cosmos#13207)

    * Reduce user password prompts by taking advantage of the already existing MigrateAll function

    * Print message when no records were found on the keyring

    * Update changelog

    * Fix migration test

    * Add keys sort

    (cherry picked from commit 4882f93)

    # Conflicts:
    #	CHANGELOG.md

    * fix conflicts

    * suggestions

    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

    Co-authored-by: Ezequiel Raynaudo <raynaudo.ee@gmail.com>
    Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
    Co-authored-by: Julien Robert <julien@rbrt.fr>
    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

commit c351441
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Fri Sep 23 08:26:34 2022 -0500

    docs: guidelines for proto message's String() method (cosmos#13364) (cosmos#13366)

    (cherry picked from commit 8dd708d)

    Co-authored-by: likhita-809 <78951027+likhita-809@users.noreply.github.com>

commit 72f8923
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Fri Sep 23 08:16:20 2022 -0500

    feat: add `draft-proposal` for x/group (backport cosmos#13353) (cosmos#13359)

    * feat: add `draft-proposal` for x/group (cosmos#13353)

    * feat: add `draft-proposal` for x/group

    * add changelog

    * extract useful function

    * add `GetMsgFromTypeURL` tests

    (cherry picked from commit 7eb259f)

    # Conflicts:
    #	CHANGELOG.md
    #	types/tx_msg.go
    #	x/gov/client/cli/prompt.go

    * fix conflicts

    * fix whitespace

    * backport cosmos#13350

    * renaming as main

    * updates

    Co-authored-by: Julien Robert <julien@rbrt.fr>

commit 9454b97
Author: Julien Robert <julien@rbrt.fr>
Date:   Tue Sep 20 18:02:24 2022 +0200

    fix: fix buf commit (cosmos#13344)

commit bbcf2f1
Author: Julien Robert <julien@rbrt.fr>
Date:   Tue Sep 20 17:04:54 2022 +0200

    fix: fix buf unexisting repo (cosmos#13343)

commit f57a110
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Tue Sep 20 16:30:54 2022 +0200

    fix: ensure withdraw_rewards events are always emitted on reward withdrawal (backport cosmos#13323) (cosmos#13339)

    * fix: ensure withdraw_rewards events are always emitted on reward withdrawal (cosmos#13323)

    (cherry picked from commit c1c23a7)

    # Conflicts:
    #	CHANGELOG.md
    #	tests/integration/distribution/keeper/delegation_test.go
    #	testutil/sims/app_helpers.go
    #	x/distribution/keeper/delegation.go
    #	x/distribution/keeper/delegation_test.go
    #	x/distribution/keeper/keeper.go

    * fix changelog

    * fix conflcits

    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
    Co-authored-by: Julien Robert <julien@rbrt.fr>

commit 43f74d3
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Tue Sep 20 16:29:50 2022 +0200

    feat: configurable fastnode (backport cosmos#13321) (cosmos#13337)

    * feat: configurable fastnode (cosmos#13321)

    (cherry picked from commit 412e2fc)

    # Conflicts:
    #	CHANGELOG.md
    #	fuzz/tests/store_internal_proofs_createnonmembershipproof_test.go
    #	go.mod
    #	go.sum
    #	simapp/go.mod
    #	simapp/go.sum
    #	tests/go.mod
    #	tests/go.sum

    * fix conflicts

    * test fix build

    * test fix build

    * fix typo

    * fix replace

    Co-authored-by: Marko <marbar3778@yahoo.com>

commit 6c8614c
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Tue Sep 20 10:40:42 2022 +0200

    fix: streaming listeners are not called for deliver tx event (backport cosmos#13334) (cosmos#13336)

    * fix: streaming listeners are not called for deliver tx event (cosmos#13334)

    * Problem: streaming listeners are not called for deliver tx event

    it was removed accidentally, add back.

    * Update CHANGELOG.md

    * try to fix e2e test by wait for one more block

    (cherry picked from commit 822900b)

    # Conflicts:
    #	CHANGELOG.md
    #	x/auth/tx/service_test.go

    * Update CHANGELOG.md

    * Update x/auth/tx/service_test.go

    * Update x/auth/tx/service_test.go

    Co-authored-by: yihuang <huang@crypto.com>

commit 100db2e
Author: Julien Robert <julien@rbrt.fr>
Date:   Mon Sep 19 16:00:44 2022 +0200

    fix: remove community-pool-spend from draft-cli prompt (cosmos#13330)

commit ef0f19c
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Mon Sep 19 13:35:08 2022 +0000

    feat: CLI tooling to generate proposal JSONs (backport cosmos#13304) (cosmos#13328)

    * feat: CLI tooling to generate proposal JSONs (cosmos#13304)

    (cherry picked from commit 7252f4a)

    # Conflicts:
    #	CHANGELOG.md
    #	api/cosmos/nft/v1beta1/tx.pulsar.go
    #	go.mod
    #	go.sum
    #	simapp/go.mod
    #	simapp/go.sum
    #	tests/go.mod
    #	tests/go.sum
    #	x/gov/README.md
    #	x/group/spec/05_client.md

    * fix changelog

    * remove unnecessary addition

    * updates

    * fix docs

    * updates

    Co-authored-by: Julien Robert <julien@rbrt.fr>

commit c524571
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Fri Sep 16 16:03:13 2022 +0200

    fix: keep the balance query endpoint compatible with legacy blocks (backport cosmos#13301) (cosmos#13318)

    * fix: keep the balance query endpoint compatible with legacy blocks (cosmos#13301)

    * keep the balance query endpoint compatible with legacy blocks

    Closes: cosmos#13296

    A temporary solution before the proxy tool developed, since the balance endpoint is too important.

    * Update CHANGELOG.md

    * Apply suggestions from code review

    Co-authored-by: Julien Robert <julien@rbrt.fr>
    Co-authored-by: Marko <marbar3778@yahoo.com>
    (cherry picked from commit 6c4f94b)

    # Conflicts:
    #	CHANGELOG.md
    #	x/bank/keeper/view.go

    * Apply suggestions from code review

    * fix lint

    Co-authored-by: yihuang <huang@crypto.com>
    Co-authored-by: Julien Robert <julien@rbrt.fr>

commit 51a9014
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Sep 15 16:43:38 2022 +0200

    fix: types: correctly coalesce coins even with repeated denominations & simplify logic (backport cosmos#13265) (cosmos#13302)

    * fix: types: correctly coalesce coins even with repeated denominations & simplify logic (cosmos#13265)

    (cherry picked from commit 83f88a6)

    # Conflicts:
    #	types/coin_test.go

    * fix conflict

    * add changelog

    Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>
    Co-authored-by: Julien Robert <julien@rbrt.fr>

commit ac4a066
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Wed Sep 14 10:56:13 2022 +0200

    feat: add more coins after add-genesis-account is made (backport cosmos#13233) (cosmos#13261)

    * feat: add more coins after add-genesis-account is made (cosmos#13233)

    (cherry picked from commit c32493a)

    # Conflicts:
    #	CHANGELOG.md

    * updates

    Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com>
    Co-authored-by: Julien Robert <julien@rbrt.fr>

commit 78336ef
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Wed Sep 14 09:08:25 2022 +0200

    fix: sequence in `sign-batch` (backport cosmos#13200) (cosmos#13263)

commit 77fcbbd
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Wed Sep 14 08:50:45 2022 +0200

    docs: adds gov groups metadata spec (cosmos#13118) (cosmos#13264)

commit 70943c6
Author: Julien Robert <julien@rbrt.fr>
Date:   Mon Sep 12 15:07:18 2022 +0200

    chore: pin version of golangci-lint (cosmos#13245)

commit 25e7f9b
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date:   Mon Sep 12 15:35:06 2022 +0700

    fix: make 46's linter work (cosmos#13186)

commit 8121f34
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Fri Sep 9 10:28:02 2022 +0200

    fix: Add withdraw proposal cmd to group's CLI tx cmds (backport cosmos#13214) (cosmos#13216)

commit 095c2b0
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Fri Sep 2 16:01:21 2022 +0200

    chore: replace deprecated dgrijalva/jwt-go dep (backport cosmos#13093) (cosmos#13136)

    * chore: replace deprecated dgrijalva/jwt-go dep (cosmos#13093)

    * chore: replace deprecated dgrijalva/jwt-go dep

    * Update go.mod

    (cherry picked from commit f5f84ad)

    # Conflicts:
    #	go.mod
    #	go.sum

    * fix conflict

    Co-authored-by: Robert Zaremba <robert@zaremba.ch>
    Co-authored-by: Julien Robert <julien@rbrt.fr>

commit 9405a05
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Fri Sep 2 07:32:08 2022 +0200

    feat: Add a cli cmd to prune old states according to current settings (backport cosmos#12742) (cosmos#13119)

    * feat: Add a cli cmd to prune old states according to current settings (cosmos#12742)

    * add PruningCmd and change PruneStores signature

    * the mimimum default pruning interval is 10

    Co-authored-by: Marko <marbar3778@yahoo.com>
    (cherry picked from commit d874ace)

    * fix backport error

    Co-authored-by: adu-crypto <94821467+adu-crypto@users.noreply.github.com>
    Co-authored-by: adu <adu.du@crypto.com>

commit a95c626
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Wed Aug 31 14:21:02 2022 +0200

    fix: rollback command don't actually delete multistore versions (backport cosmos#11361) (cosmos#13089)

    * fix: rollback command don't actually delete multistore versions (cosmos#11361)

    * rollback command don't actually delete multistore versions

    Closes: cosmos#11333

    - add unit tests
    - use LoadVersionForOverwriting
    - update tendermint dependency to 0.35.x release branch

    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

    flushMetadata after rollback

    Update server/rollback.go

    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

    fix build

    gofumpt

    * fix unit test

    (cherry picked from commit 51d2de5)

    * fix unit test

    * changelog

    * api breaking changelog

    Co-authored-by: yihuang <huang@crypto.com>

commit 78c24eb
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Wed Aug 31 14:04:56 2022 +0200

    fix: call `SetIAVLCacheSize` with the configured value in simapp (backport cosmos#13107) (cosmos#13108)

    * fix: call `SetIAVLCacheSize` with the configured value in simapp (cosmos#13107)

    * Call `SetIAVLCacheSize` with the configured value in simapp.

    * Update CHANGELOG.md

    (cherry picked from commit ab33342)

    # Conflicts:
    #	CHANGELOG.md

    * Apply suggestions from code review

    Co-authored-by: yihuang <huang@crypto.com>

commit bb190f6
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Mon Aug 29 11:36:24 2022 +0000

    chore: bump gin-gonic dep (backport cosmos#13061) (cosmos#13062)

    * deps: bump gin-gonic (cosmos#13061)

    Co-authored-by: Julien Robert <julien@rbrt.fr>
    (cherry picked from commit d11196a)

    # Conflicts:
    #	go.sum

    * fix conflicts

    Co-authored-by: Robert Zaremba <robert@zaremba.ch>
    Co-authored-by: marbar3778 <marbar3778@yahoo.com>

commit 1af5c72
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Sat Aug 27 09:18:50 2022 +0200

    feat(x/auth): Add auth sim decoder case for AccountNumberStoreKeyPrefix (backport cosmos#13048) (cosmos#13054)

commit e2fe96a
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Fri Aug 26 13:16:02 2022 -0400

    feat(x/authz): Add the GetAuthorization function. (backport cosmos#13047) (cosmos#13052)

    * feat(x/authz): Add the GetAuthorization function. (cosmos#13047)

    * [13027]: Create the GetAuthorization function (in the authz module).

    * [13027]: Add unit tests for the new GetAuthorization function.

    * [13027]: Add changelog entry.

    (cherry picked from commit 5e4651e)

    # Conflicts:
    #	CHANGELOG.md
    #	x/authz/keeper/keeper_test.go

    * fix changelog

    * Fix failed merge.

    * Fix build issue introduced by merge.

    Co-authored-by: Daniel Wedul <github@wedul.com>
    Co-authored-by: Julien Robert <julien@rbrt.fr>

commit b9d4ed8
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Aug 25 15:15:13 2022 -0400

    fix: missing return statement in BaseApp.Query (backport cosmos#13046) (cosmos#13049)

    * fix: missing return statement in BaseApp.Query (cosmos#13046)

    ## Description

    Closes: cosmos#13040

    ---

    ### Author Checklist

    *All items are required. Please add a note to the item if the item is not applicable and
    please add links to any relevant follow up issues.*

    I have...

    - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] added `!` to the type prefix if API or client breaking change
    - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
    - [ ] provided a link to the relevant issue or specification
    - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
    - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
    - [ ] added a changelog entry to `CHANGELOG.md`
    - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
    - [ ] updated the relevant documentation or specification
    - [ ] reviewed "Files changed" and left comments if necessary
    - [ ] confirmed all CI checks have passed

    ### Reviewers Checklist

    *All items are required. Please add a note if the item is not applicable and please add
    your handle next to the items reviewed if you only reviewed selected items.*

    I have...

    - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] confirmed `!` in the type prefix if API or client breaking change
    - [ ] confirmed all author checklist items have been addressed
    - [ ] reviewed state machine logic
    - [ ] reviewed API design and naming
    - [ ] reviewed documentation is accurate
    - [ ] reviewed tests and test coverage
    - [ ] manually tested (if applicable)

    (cherry picked from commit c73171f)

    # Conflicts:
    #	CHANGELOG.md

    * fix conflicts

    Co-authored-by: Julien Robert <julien@rbrt.fr>

commit 704fff5
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Aug 25 14:30:04 2022 +0200

    fix: exporting the blockParams regression (backport cosmos#13029) (cosmos#13037)

    * fix: exporting the blockParams regression (cosmos#13029)

    ## Description

    Closes: cosmos#13024

    ---

    ### Author Checklist

    *All items are required. Please add a note to the item if the item is not applicable and
    please add links to any relevant follow up issues.*

    I have...

    - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [x] added `!` to the type prefix if API or client breaking change
    - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
    - [x] provided a link to the relevant issue or specification
    - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
    - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
    - [x] added a changelog entry to `CHANGELOG.md`
    - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
    - [ ] updated the relevant documentation or specification
    - [x] reviewed "Files changed" and left comments if necessary
    - [ ] confirmed all CI checks have passed

    ### Reviewers Checklist

    *All items are required. Please add a note if the item is not applicable and please add
    your handle next to the items reviewed if you only reviewed selected items.*

    I have...

    - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] confirmed `!` in the type prefix if API or client breaking change
    - [ ] confirmed all author checklist items have been addressed
    - [ ] reviewed state machine logic
    - [ ] reviewed API design and naming
    - [ ] reviewed documentation is accurate
    - [ ] reviewed tests and test coverage
    - [ ] manually tested (if applicable)

    (cherry picked from commit e1999e4)

    # Conflicts:
    #	CHANGELOG.md
    #	server/export_test.go

    * fix conflicts

    Co-authored-by: JayT106 <JayT106@users.noreply.github.com>
    Co-authored-by: Julien Robert <julien@rbrt.fr>

commit cb7bdca
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Wed Aug 24 15:15:28 2022 -0400

    ci: fix release notes not populated by goreleaser (backport cosmos#12919) (cosmos#13018)

    * ci: fix release notes not populated by goreleaser

    (cherry picked from commit c670fec)

    # Conflicts:
    #	cosmovisor/go.mod
    #	cosmovisor/go.sum
    #	go.work.sum

    * updates

    * revert

    Co-authored-by: Julien Robert <julien@rbrt.fr>

commit 252c673
Author: Julien Robert <julien@rbrt.fr>
Date:   Wed Aug 24 17:43:33 2022 +0200

    chore: v0.46.1 release changelog (cosmos#13011)

    * chore: v0.46.1 release changelog

    * updates

    * updates

commit 60e6274
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Wed Aug 24 16:45:44 2022 +0200

    feat: Change the default priority mechanism to be based on gas price (backport cosmos#12953) (cosmos#13006)

    * feat: Change the default priority mechanism to be based on gas price (cosmos#12953)

    (cherry picked from commit befd816)

    # Conflicts:
    #	CHANGELOG.md
    #	x/auth/ante/fee_test.go

    * fix conflict

    Co-authored-by: yihuang <huang@crypto.com>
    Co-authored-by: Julien Robert <julien@rbrt.fr>

commit afb3def
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Tue Aug 23 14:54:38 2022 -0400

    docs: improve UPGRADING.md instructions for v0.46.0 (backport cosmos#12646) (cosmos#13004)

    * docs: improve UPGRADING.md instructions for v0.46.0 (cosmos#12646)

    ## Description

    This PR is aimed to improve further the UGPRADING.md for v0.46.0.
    We've merged cosmos#12477 for having concurrent work on the file.

    - ref cosmos#12992 and closes cosmos#12991
    - closes cosmos#12963

    ---

    ### Author Checklist

    *All items are required. Please add a note to the item if the item is not applicable and
    please add links to any relevant follow up issues.*

    I have...

    - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] added `!` to the type prefix if API or client breaking change
    - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
    - [ ] provided a link to the relevant issue or specification
    - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
    - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
    - [ ] added a changelog entry to `CHANGELOG.md`
    - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
    - [ ] updated the relevant documentation or specification
    - [ ] reviewed "Files changed" and left comments if necessary
    - [ ] confirmed all CI checks have passed

    ### Reviewers Checklist

    *All items are required. Please add a note if the item is not applicable and please add
    your handle next to the items reviewed if you only reviewed selected items.*

    I have...

    - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] confirmed `!` in the type prefix if API or client breaking change
    - [ ] confirmed all author checklist items have been addressed
    - [ ] reviewed state machine logic
    - [ ] reviewed API design and naming
    - [ ] reviewed documentation is accurate
    - [ ] reviewed tests and test coverage
    - [ ] manually tested (if applicable)

    (cherry picked from commit c76a00b)

    # Conflicts:
    #	.gitignore
    #	CHANGELOG.md
    #	Makefile
    #	UPGRADING.md

    * fix conflict

    Co-authored-by: Julien Robert <julien@rbrt.fr>

commit 90ef369
Author: Sai Kumar <17549398+gsk967@users.noreply.github.com>
Date:   Tue Aug 23 20:01:13 2022 +0530

    fix: fix the gov proposals (cosmos#13002)

commit d3d4675
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Tue Aug 23 14:11:23 2022 +0200

    fix: proper error when parsing telemetry configuration (backport cosmos#12981) (cosmos#12998)

    * fix: proper error when parsing telemetry configuration (cosmos#12981)

    When parsing `telemetry.global-labels` config the code assumes that the type will be an array.  I saw an issue where someone edited the configuration in the wrong way and got the following error:
    ![photo_2022-08-21_08-02-21](https://user-images.githubusercontent.com/22855163/185793842-c5759a54-1860-4dd1-bdb4-b94f4dab3c16.jpg)
    Instead, I suggest here to print a proper error log to indicate what the issue is.

    (cherry picked from commit c24c439)

    * add changelog

    Co-authored-by: liorbond <liorbond@gmail.com>
    Co-authored-by: Julien Robert <julien@rbrt.fr>

commit c835d46
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date:   Mon Aug 22 04:30:00 2022 +0700

    Update Makefile (cosmos#12982)

    formatting

commit 7ee9e6d
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Fri Aug 19 18:26:49 2022 +0200

    docs(cli): improve --gas flag description (cosmos#12913) (cosmos#12965)

    * docs(cli): improve --gas flag description

    * Update client/flags/flags.go

    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

    * fix sprintf

    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
    Co-authored-by: Julien Robert <julien@rbrt.fr>
    (cherry picked from commit f430528)

    Co-authored-by: Robert Zaremba <robert@zaremba.ch>

commit f31c795
Author: Julien Robert <julien@rbrt.fr>
Date:   Fri Aug 19 18:26:07 2022 +0200

    chore: bump tendermint to `0.34.21` and iavl to `0.19.1` (cosmos#12969)

    * chore: bump tendermint to `0.34.21` and iavl to `0.19.1`

    * update changelog

commit 32c9075
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Aug 18 15:34:32 2022 -0400

    fix: the occasional  staking module `SimulateMsgCancelUnbondingDelegate` failure (backport cosmos#12933) (cosmos#12962)

commit d2a5018
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Aug 18 15:34:09 2022 -0400

    feat: deterministic map iteration (backport cosmos#12781) (cosmos#12943)

commit f3c1d8c
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Aug 18 15:33:52 2022 -0400

    perf: Amortize clearing unsorted cache entries (Juno genesis fix) (backport cosmos#12885) (cosmos#12960)

commit 629b3b9
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Aug 11 10:32:48 2022 -0400

    fix: move downgrade verification after store migration (cosmos#12906) (cosmos#12907)

commit d74d102
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Wed Aug 10 16:16:53 2022 +0200

    fix(x/group): propagate events correctly to current context (backport cosmos#12888) (cosmos#12890)

    * fix(x/group): propagate events correctly to current context (cosmos#12888)

    * fix(x/groups) propagate events correctly to current context

    * update to use current context on logger

    * adding changelog entry

    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
    (cherry picked from commit 014bfae)

    # Conflicts:
    #	CHANGELOG.md

    * fix conflicts

    Co-authored-by: Damian Nolan <damiannolan@gmail.com>
    Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com>

commit 5caee00
Author: Robert Zaremba <robert@zaremba.ch>
Date:   Wed Aug 10 10:02:13 2022 +0200

    chore: bump math (cosmos#12877)

    * chore: bump math package

    * changelog

commit 69c88ad
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Mon Aug 8 17:22:58 2022 -0400

    chore: changelog update (backport cosmos#12859) (cosmos#12861)

commit e5b974c
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Mon Aug 8 15:13:12 2022 -0400

    chore: fee payer event (cosmos#12850) (cosmos#12855)

commit 137bd03
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Sun Aug 7 22:39:42 2022 +0200

    Update REST endpoints for group module documentation (cosmos#12839) (cosmos#12840)

    (cherry picked from commit cfed17e)

    Co-authored-by: lg <8335464+glnro@users.noreply.github.com>

commit 2b616fb
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Sun Aug 7 09:43:59 2022 -0400

    fix(docs): typo in staking/state (cosmos#12834) (cosmos#12835)

    (cherry picked from commit fe89212)

    Co-authored-by: Ari Rubinstein <arirubinstein@users.noreply.github.com>

commit 1890b8b
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Tue Aug 2 10:26:49 2022 +0200

    feat: Add GetParamSetIfExists to prevent panic on breaking param changes (backport cosmos#12615) (cosmos#12792)

    * feat: Add GetParamSetIfExists to prevent panic on breaking param changes (cosmos#12615)

    * imp(params): Add GetParamSetIfExists to prevent panic on breaking param changes

    * changelog

    * test

    Co-authored-by: Marko <marbar3778@yahoo.com>
    (cherry picked from commit 2932e11)

    # Conflicts:
    #	CHANGELOG.md

    * Update CHANGELOG.md

    Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
    Co-authored-by: Marko <marbar3778@yahoo.com>

commit 04e7ab1
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Wed Jul 27 16:46:05 2022 +0200

    feat: Add convenience method for constructing key to access account's balance for a given denom (backport cosmos#12674) (cosmos#12744)

    * feat: Add convenience method for constructing key to access account's balance for a given denom (cosmos#12674)

    This PR adds a convenience method for constructing the key necessary to query for the account's balance of a given denom.

    I ran into this issue since we are using ABCI query now to perform balance requests because we are also requesting merkle proofs for the returned balance [here](https://github.com/celestiaorg/celestia-node/pull/911/files#diff-0ee31f5a7bd88e9f758e6bebdf3ee36365519e55a451098d9638c39afe5eac42R144).

    It would be nice to have a definitive convenience method for constructing the key.

    [Ref.](github.com/celestiaorg/celestia-node/pull/911)

    (cherry picked from commit a1777a8)

    * updates changelog

    Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
    Co-authored-by: Julien Robert <julien@rbrt.fr>
  • Loading branch information
SpicyLemon committed Oct 3, 2022
1 parent b08ec4b commit d142c29
Show file tree
Hide file tree
Showing 269 changed files with 3,232 additions and 4,072 deletions.
27 changes: 11 additions & 16 deletions .github/workflows/lint.yml
@@ -1,31 +1,26 @@
name: Lint
# Lint runs golangci-lint over the entire cosmos-sdk repository
# This workflow is run on every pull request and push to main
# The `golangci` will pass without running if no *.{go, mod, sum} files have been changed.
on:
pull_request:
push:
tags:
- v*
branches:
- main
pull_request:
permissions:
contents: read
# Optional: allow read access to pull request. Use with `only-new-issues` option.
# pull-requests: read
jobs:
golangci:
name: golangci-lint
runs-on: ubuntu-latest
steps:
- uses: actions/setup-go@v3
with:
go-version: 1.18
- uses: technote-space/get-diff-action@v6.0.1
id: git_diff
with:
PATTERNS: |
**/**.go
go.mod
go.sum
go-version: 1.19
- uses: actions/checkout@v3
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
version: latest
args: --out-format=tab
skip-go-installation: true
if: env.GIT_DIFF
# Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
version: v1.49.0
23 changes: 5 additions & 18 deletions .golangci.yml
Expand Up @@ -6,45 +6,30 @@ run:
linters:
disable-all: true
enable:
- bodyclose
- deadcode
- depguard
- dogsled
# - errcheck
- exportloopref
- goconst
- gocritic
- gofmt
- goimports
- gofumpt
- gosec
- gosimple
- govet
- ineffassign
- misspell
- nakedret
- nolintlint
- prealloc
- revive
- staticcheck
- structcheck
- stylecheck
- typecheck
- unconvert
- unparam
- unused
# - wsl

issues:
exclude-rules:
- text: "Use of weak random number generator"
linters:
- gosec
- text: "comment on exported var"
linters:
- golint
- text: "don't use an underscore in package name"
linters:
- golint
- text: "ST1003:"
linters:
- stylecheck
Expand All @@ -53,6 +38,9 @@ issues:
- text: "ST1016:"
linters:
- stylecheck
- text: "should be written without leading space as"
linters:
- nolintlint
- path: "migrations"
text: "SA1019:"
linters:
Expand All @@ -69,6 +57,5 @@ linters-settings:
suggest-new: true
nolintlint:
allow-unused: false
allow-leading-space: true
require-explanation: false
require-specific: false
require-specific: false
2 changes: 1 addition & 1 deletion .goreleaser.yml
Expand Up @@ -24,4 +24,4 @@ snapshot:
name_template: SNAPSHOT-{{ .Commit }}

changelog:
skip: true
skip: false
131 changes: 127 additions & 4 deletions CHANGELOG.md
Expand Up @@ -106,6 +106,41 @@ It also contains the customizations that were included in [v0.45.5-pio-1](https:

# Cosmos-SDK releases

## [v0.46.2](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.46.2) - 2022-10-03

### API Breaking Changes

* (cli) [#13089](https://github.com/cosmos/cosmos-sdk/pull/13089) Fix rollback command don't actually delete multistore versions, added method `RollbackToVersion` to interface `CommitMultiStore` and added method `CommitMultiStore` to `Application` interface.
* (cli) [#13089](https://github.com/cosmos/cosmos-sdk/pull/13089) `NewRollbackCmd` now takes an `appCreator types.AppCreator`.

### Features

* (cli) [#13207](https://github.com/cosmos/cosmos-sdk/pull/13207) Reduce user's password prompts when calling keyring `List()` function.
* (cli) [#13353](https://github.com/cosmos/cosmos-sdk/pull/13353) Add `tx group draft-proposal` command for generating group proposal JSONs (skeleton).
* (cli) [#13304](https://github.com/cosmos/cosmos-sdk/pull/13304) Add `tx gov draft-proposal` command for generating proposal JSONs (skeleton).
* (x/authz) [#13047](https://github.com/cosmos/cosmos-sdk/pull/13047) Add a GetAuthorization function to the keeper.
* (cli) [#12742](https://github.com/cosmos/cosmos-sdk/pull/12742) Add the `prune` CLI cmd to manually prune app store history versions based on the pruning options.

### Improvements

* [#13323](https://github.com/cosmos/cosmos-sdk/pull/13323) Ensure `withdraw_rewards` rewards are emitted from all actions that result in rewards being withdrawn.
* [#13233](https://github.com/cosmos/cosmos-sdk/pull/13233) Add `--append` to `add-genesis-account` sub-command to append new tokens after an account is already created.
* (x/group) [#13214](https://github.com/cosmos/cosmos-sdk/pull/13214) Add `withdraw-proposal` command to group module's CLI transaction commands.
* (x/auth) [#13048](https://github.com/cosmos/cosmos-sdk/pull/13048) Add handling of AccountNumberStoreKeyPrefix to the simulation decoder.
* (simapp) [#13108](https://github.com/cosmos/cosmos-sdk/pull/13108) Call `SetIAVLCacheSize` with the configured value in simapp.
* [#13318](https://github.com/cosmos/cosmos-sdk/pull/13318) Keep the balance query endpoint compatible with legacy blocks.
* [#13321](https://github.com/cosmos/cosmos-sdk/pull/13321) Add flag to disable fast node migration and usage.

### Bug Fixes

* (types) [#13265](https://github.com/cosmos/cosmos-sdk/pull/13265) Correctly coalesce coins even with repeated denominations & simplify logic.
* (x/auth) [#13200](https://github.com/cosmos/cosmos-sdk/pull/13200) Fix wrong sequences in `sign-batch`.
* (export) [#13029](https://github.com/cosmos/cosmos-sdk/pull/13029) Fix exporting the blockParams regression.
* [#13046](https://github.com/cosmos/cosmos-sdk/pull/13046) Fix missing return statement in BaseApp.Query.
* (store) [#13336](https://github.com/cosmos/cosmos-sdk/pull/13336) Call streaming listeners for deliver tx event, it was removed accidentally, backport #13334.
* (grpc) [#13417](https://github.com/cosmos/cosmos-sdk/pull/13417) fix grpc query panic that could crash the node (backport #13352).
* (grpc) [#13418](https://github.com/cosmos/cosmos-sdk/pull/13418) Add close for grpc only mode.

## [v0.46.1](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.46.1) - 2022-08-24

### Improvements
Expand Down Expand Up @@ -430,8 +465,96 @@ It also contains the customizations that were included in [v0.45.5-pio-1](https:

### Deprecated

* (x/upgrade) [\#9906](https://github.com/cosmos/cosmos-sdk/pull/9906) Deprecate `UpgradeConsensusState` gRPC query since this functionality is only used for IBC, which now has its own [IBC replacement](https://github.com/cosmos/ibc-go/blob/2c880a22e9f9cc75f62b527ca94aa75ce1106001/proto/ibc/core/client/v1/query.proto#L54)
* (types) [\#10948](https://github.com/cosmos/cosmos-sdk/issues/10948) Deprecate the types.DBBackend variable and types.NewLevelDB function. They are replaced by a new entry in `app.toml`: `app-db-backend` and `tendermint/tm-db`s `NewDB` function. If `app-db-backend` is defined, then it is used. Otherwise, if `types.DBBackend` is defined, it is used (until removed: [\#11241](https://github.com/cosmos/cosmos-sdk/issues/11241)). Otherwise, Tendermint config's `db-backend` is used.
* (x/upgrade) [#9906](https://github.com/cosmos/cosmos-sdk/pull/9906) Deprecate `UpgradeConsensusState` gRPC query since this functionality is only used for IBC, which now has its own [IBC replacement](https://github.com/cosmos/ibc-go/blob/2c880a22e9f9cc75f62b527ca94aa75ce1106001/proto/ibc/core/client/v1/query.proto#L54)
* (types) [#10948](https://github.com/cosmos/cosmos-sdk/issues/10948) Deprecate the types.DBBackend variable and types.NewLevelDB function. They are replaced by a new entry in `app.toml`: `app-db-backend` and `tendermint/tm-db`s `NewDB` function. If `app-db-backend` is defined, then it is used. Otherwise, if `types.DBBackend` is defined, it is used (until removed: [#11241](https://github.com/cosmos/cosmos-sdk/issues/11241)). Otherwise, Tendermint config's `db-backend` is used.

## v0.45.8 - 2022-08-25

### Improvements

* [#12981](https://github.com/cosmos/cosmos-sdk/pull/12981) Return proper error when parsing telemetry configuration.
* [#12885](https://github.com/cosmos/cosmos-sdk/pull/12885) Amortize cost of processing cache KV store.
* [#12970](https://github.com/cosmos/cosmos-sdk/pull/12970) Bump Tendermint to `v0.34.21` and IAVL to `v0.19.1`.
* [#12693](https://github.com/cosmos/cosmos-sdk/pull/12693) Make sure the order of each node is consistent when emitting proto events.

### Bug Fixes

* [#13046](https://github.com/cosmos/cosmos-sdk/pull/13046) Fix missing return statement in BaseApp.Query.

## v0.45.7 - 2022-08-04

### Features

* (upgrade) [#12603](https://github.com/cosmos/cosmos-sdk/pull/12603) feat: Move AppModule.BeginBlock and AppModule.EndBlock to extension interfaces

### Improvements

* (events) [#12850](https://github.com/cosmos/cosmos-sdk/pull/12850) Add a new `fee_payer` attribute to the `tx` event that is emitted from the `DeductFeeDecorator` AnteHandler decorator.
* (x/params) [#12724](https://github.com/cosmos/cosmos-sdk/pull/12724) Add `GetParamSetIfExists` function to params `Subspace` to prevent panics on breaking changes.
* [#12668](https://github.com/cosmos/cosmos-sdk/pull/12668) Add `authz_msg_index` event attribute to message events emitted when executing via `MsgExec` through `x/authz`.
* [#12697](https://github.com/cosmos/cosmos-sdk/pull/12697) Upgrade IAVL to v0.19.0 with fast index and error propagation. NOTE: first start will take a while to propagate into new model.
* Note: after upgrading to this version it may take up to 15 minutes to migrate from 0.17 to 0.19. This time is used to create the fast cache introduced into IAVL for performance
* [#12784](https://github.com/cosmos/cosmos-sdk/pull/12784) Upgrade Tendermint to 0.34.20.
* (x/bank) [#12674](https://github.com/cosmos/cosmos-sdk/pull/12674) Add convenience function `CreatePrefixedAccountStoreKey()` to construct key to access account's balance for a given denom.

### Bug Fixes

* (x/mint) [#12384](https://github.com/cosmos/cosmos-sdk/pull/12384) Ensure `GoalBonded` must be positive when performing `x/mint` parameter validation.
* (simapp) [#12437](https://github.com/cosmos/cosmos-sdk/pull/12437) fix the non-determinstic behavior in simulations caused by `GenTx` and check
empty coins slice before it is used to create `banktype.MsgSend`.
* (x/capability) [12818](https://github.com/cosmos/cosmos-sdk/pull/12818) Use fixed length hex for pointer at FwdCapabilityKey.

## [v0.45.6](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.45.6) - 2022-06-28

### Improvements

* (simapp) [#12314](https://github.com/cosmos/cosmos-sdk/pull/12314) Increase `DefaultGenTxGas` from `1000000` to `10000000`
* [#12371](https://github.com/cosmos/cosmos-sdk/pull/12371) Update min required Golang version to 1.18.

### Bug Fixes

* [#12317](https://github.com/cosmos/cosmos-sdk/pull/12317) Rename `edit-validator` command's `--moniker` flag to `--new-moniker`
* (x/upgrade) [#12264](https://github.com/cosmos/cosmos-sdk/pull/12264) Fix `GetLastCompleteUpgrade` to properly return the latest upgrade.
* (x/crisis) [#12208](https://github.com/cosmos/cosmos-sdk/pull/12208) Fix progress index of crisis invariant assertion logs.

### Features

* (query) [#12253](https://github.com/cosmos/cosmos-sdk/pull/12253) Add `GenericFilteredPaginate` to the `query` package to improve UX.

## [v0.45.5](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.45.5) - 2022-06-09

### Improvements

* (x/feegrant) [#11813](https://github.com/cosmos/cosmos-sdk/pull/11813) Fix pagination total count in `AllowancesByGranter` query.
* (errors) [#12002](https://github.com/cosmos/cosmos-sdk/pull/12002) Removed 'redacted' error message from defaultErrEncoder.
* (ante) [#12017](https://github.com/cosmos/cosmos-sdk/pull/12017) Index ante events for failed tx (backport #12013).
* [#12153](https://github.com/cosmos/cosmos-sdk/pull/12153) Add a new `NewSimulationManagerFromAppModules` constructor, to simplify simulation wiring.

### Bug Fixes

* [#11796](https://github.com/cosmos/cosmos-sdk/pull/11796) Handle EOF error case in `readLineFromBuf`, which allows successful reading of passphrases from STDIN.
* [#11772](https://github.com/cosmos/cosmos-sdk/pull/11772) Limit types.Dec length to avoid overflow.
* [#10947](https://github.com/cosmos/cosmos-sdk/pull/10947) Add `AllowancesByGranter` query to the feegrant module
* [#9639](https://github.com/cosmos/cosmos-sdk/pull/9639) Check store keys length before accessing them by making sure that `key` is of length `m+1` (for `key[n:m]`)
* [#11983](https://github.com/cosmos/cosmos-sdk/pull/11983) (x/feegrant, x/authz) rename grants query commands to `grants-by-grantee`, `grants-by-granter` cmds.

## Improvements

* [#11886](https://github.com/cosmos/cosmos-sdk/pull/11886) Improve error messages

## [v0.45.4](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.45.4) - 2022-04-25

### Bug Fixes

* [#11624](https://github.com/cosmos/cosmos-sdk/pull/11624) Handle the error returned from `NewNode` in the `server` package.
* [#11724](https://github.com/cosmos/cosmos-sdk/pull/11724) Fix data race issues with `api.Server`.

### Improvements

* (types) [#12201](https://github.com/cosmos/cosmos-sdk/pull/12201) Add `MustAccAddressFromBech32` util function
* [#11693](https://github.com/cosmos/cosmos-sdk/pull/11693) Add validation for gentx cmd.
* [#11686](https://github.com/cosmos/cosmos-sdk/pull/11686) Update the min required Golang version to `1.17`.
* (x/auth/vesting) [#11652](https://github.com/cosmos/cosmos-sdk/pull/11652) Add util functions for `Period(s)`

## [v0.45.3](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.45.3) - 2022-04-12

Expand Down Expand Up @@ -3470,7 +3593,7 @@ BREAKING CHANGES
* SDK
* [baseapp] Msgs are no longer run on CheckTx, removed `ctx.IsCheckTx()`
* [baseapp] NewBaseApp constructor takes sdk.TxDecoder as argument instead of wire.Codec
* [types] sdk.NewCoin takes sdk.Int, sdk.NewInt64Coin takes int64
* [types] sdk.NewCoin takes math.Int, sdk.NewInt64Coin takes int64
* [x/auth] Default TxDecoder can be found in `x/auth` rather than baseapp
* [client] [\#1551](https://github.com/cosmos/cosmos-sdk/issues/1551): Refactored `CoreContext` to `TxContext` and `QueryContext`
* Removed all tx related fields and logic (building & signing) to separate
Expand Down Expand Up @@ -3796,7 +3919,7 @@ BREAKING CHANGES

* msg.GetSignBytes() now returns bech32-encoded addresses in all cases
* [lcd] REST end-points now include gas
* sdk.Coin now uses sdk.Int, a big.Int wrapper with 256bit range cap
* sdk.Coin now uses math.Int, a big.Int wrapper with 256bit range cap

FEATURES

Expand Down
58 changes: 17 additions & 41 deletions Makefile
Expand Up @@ -349,26 +349,24 @@ benchmark:
### Linting ###
###############################################################################

markdownLintImage=tmknom/markdownlint
containerMarkdownLint=$(PROJECT_NAME)-markdownlint
containerMarkdownLintFix=$(PROJECT_NAME)-markdownlint-fix

golangci_lint_cmd=golangci-lint
golangci_version=v1.49.0

lint: lint-go
@if docker ps -a --format '{{.Names}}' | grep -Eq "^${containerMarkdownLint}$$"; then docker start -a $(containerMarkdownLint); else docker run --name $(containerMarkdownLint) -i -v "$(CURDIR):/work" $(markdownLintImage); fi
lint:
@echo "--> Running linter"
@go install github.com/golangci/golangci-lint/cmd/golangci-lint@$(golangci_version)
@$(golangci_lint_cmd) run --timeout=10m

lint-fix:
golangci-lint run --fix --out-format=tab --issues-exit-code=0
@if docker ps -a --format '{{.Names}}' | grep -Eq "^${containerMarkdownLintFix}$$"; then docker start -a $(containerMarkdownLintFix); else docker run --name $(containerMarkdownLintFix) -i -v "$(CURDIR):/work" $(markdownLintImage) . --fix; fi

lint-go:
@@test -n "$$golangci-lint version | awk '$4 >= 1.42')"
$(golangci_lint_cmd) run --out-format=tab $(GIT_DIFF)
@echo "--> Running linter"
@go install github.com/golangci/golangci-lint/cmd/golangci-lint@$(golangci_version)
@$(golangci_lint_cmd) run --fix --out-format=tab --issues-exit-code=0

.PHONY: lint lint-fix

format:
@go install mvdan.cc/gofumpt@latest
@go install github.com/golangci/golangci-lint/cmd/golangci-lint@$(golangci_version)
find . -name '*.go' -type f -not -path "./vendor*" -not -path "*.git*" -not -path "./client/docs/statik/statik.go" -not -path "./tests/mocks/*" -not -name "*.pb.go" -not -name "*.pb.gw.go" -not -name "*.pulsar.go" -not -path "./crypto/keys/secp256k1/*" | xargs gofumpt -w -l
golangci-lint run --fix
.PHONY: format
Expand Down Expand Up @@ -440,34 +438,18 @@ proto-lint:
proto-check-breaking:
@$(DOCKER_BUF) breaking --against $(HTTPS_GIT)#branch=main


TM_URL = https://raw.githubusercontent.com/tendermint/tendermint/v0.34.21/proto/tendermint
GOGO_PROTO_URL = https://raw.githubusercontent.com/regen-network/protobuf/v1.3.3-alpha.regen.1
COSMOS_PROTO_URL = https://raw.githubusercontent.com/regen-network/cosmos-proto/v0.3.1
CONFIO_URL = https://raw.githubusercontent.com/confio/ics23/go/v0.7.0

TM_CRYPTO_TYPES = third_party/proto/tendermint/crypto
TM_ABCI_TYPES = third_party/proto/tendermint/abci
TM_TYPES = third_party/proto/tendermint/types
TM_VERSION = third_party/proto/tendermint/version
TM_LIBS = third_party/proto/tendermint/libs/bits
TM_P2P = third_party/proto/tendermint/p2p

GOGO_PROTO_TYPES = third_party/proto/gogoproto
COSMOS_PROTO_TYPES = third_party/proto/cosmos_proto
CONFIO_TYPES = third_party/proto/confio
TM_CRYPTO_TYPES = proto/tendermint/crypto
TM_ABCI_TYPES = proto/tendermint/abci
TM_TYPES = proto/tendermint/types
TM_VERSION = proto/tendermint/version
TM_LIBS = proto/tendermint/libs/bits
TM_P2P = proto/tendermint/p2p

proto-update-deps:
@mkdir -p $(GOGO_PROTO_TYPES)
@curl -sSL $(GOGO_PROTO_URL)/gogoproto/gogo.proto > $(GOGO_PROTO_TYPES)/gogo.proto

@mkdir -p $(COSMOS_PROTO_TYPES)
@curl -sSL $(COSMOS_PROTO_URL)/cosmos.proto > $(COSMOS_PROTO_TYPES)/cosmos.proto
@echo "Updating Protobuf dependencies"

## Importing of tendermint protobuf definitions currently requires the
## use of `sed` in order to build properly with cosmos-sdk's proto file layout
## (which is the standard Buf.build FILE_LAYOUT)
## Issue link: https://github.com/tendermint/tendermint/issues/5021
@mkdir -p $(TM_ABCI_TYPES)
@curl -sSL $(TM_URL)/abci/types.proto > $(TM_ABCI_TYPES)/types.proto

Expand All @@ -491,12 +473,6 @@ proto-update-deps:
@mkdir -p $(TM_P2P)
@curl -sSL $(TM_URL)/p2p/types.proto > $(TM_P2P)/types.proto

@mkdir -p $(CONFIO_TYPES)
@curl -sSL $(CONFIO_URL)/proofs.proto > $(CONFIO_TYPES)/proofs.proto
## insert go package option into proofs.proto file
## Issue link: https://github.com/confio/ics23/issues/32
@sed -i '4ioption go_package = "github.com/confio/ics23/go";' $(CONFIO_TYPES)/proofs.proto

.PHONY: proto-all proto-gen proto-gen-any proto-swagger-gen proto-format proto-lint proto-check-breaking proto-update-deps

###############################################################################
Expand Down
2 changes: 1 addition & 1 deletion UPGRADING.md
Expand Up @@ -97,4 +97,4 @@ The `third_party/proto` folder that existed in [previous version](https://github

Instead, the SDK uses [`buf`](https://buf.build). Clients should have their own [`buf.yaml`](https://docs.buf.build/configuration/v1/buf-yaml) with `buf.build/cosmos/cosmos-sdk` as dependency, in order to avoid having to copy paste these files.

The protos can as well be downloaded using `buf export buf.build/cosmos/cosmos-sdk:$(curl -sS https://api.github.com/repos/cosmos/cosmos-sdk/commits/v0.46.0 | jq -r .sha) --output <some_folder>`.
The protos can as well be downloaded using `buf export buf.build/cosmos/cosmos-sdk:8cb30a2c4de74dc9bd8d260b1e75e176 --output <some_folder>`.

0 comments on commit d142c29

Please sign in to comment.