Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gotutorial.md #116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

bonavadeur
Copy link

wrong constant name, I changed Person_PHONE_TYPE_HOME to PhoneType_PHONE_TYPE_HOME

wrong constant name, I changed Person_PHONE_TYPE_HOME to PhoneType_PHONE_TYPE_HOME
Copy link

google-cla bot commented Jan 22, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Logofile
Copy link
Member

Thanks for your contributiont to improving/fixing the docs!

This PR is missing a CLA. Once you've agreed to the CLA, I'll be able to assess the contribution.

@Logofile
Copy link
Member

This PR is missing a CLA. Once you've agreed to the CLA, I'll be able to assess the contribution.

@bonavadeur
Copy link
Author

bonavadeur commented Apr 15, 2024 via email

@Logofile
Copy link
Member

This issue is still indicating that the cla/google check is failing. I cannot merge the PR without the CLA test passing.

@acozzette
Copy link
Member

@bonavadeur I think you will need to amend your commit to set your email address to match the one you used to sign the CLA. Otherwise the CLA checker can't verify that the CLA was signed.

@bonavadeur
Copy link
Author

@bonavadeur I think you will need to amend your commit to set your email address to match the one you used to sign the CLA. Otherwise the CLA checker can't verify that the CLA was signed.

I signed it, sorry because this is the first time I do this. But for some reason I cannot rescan checking CLA.

@Logofile
Copy link
Member

That worked; thanks! I'll see if I can get this done this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants