Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make libprotobuf symbols local on OSX (#8346) #9435

Merged
merged 1 commit into from Jan 25, 2022
Merged

Make libprotobuf symbols local on OSX (#8346) #9435

merged 1 commit into from Jan 25, 2022

Commits on Jan 22, 2022

  1. Make libprotobuf symbols local on OSX (protocolbuffers#8346) 

    @gnossen gave a great overview in grpc/grpc#24992 of the overall problem.

If a python process using both protobuf _and_ another native library linking in libprotobuf
frequently can cause crashes.  This seems to frequently affect tensorflow as well:

tensorflow/tensorflow#8394,
tensorflow/tensorflow#9525 (comment)
tensorflow/tensorflow#24976,
tensorflow/tensorflow#35573,
https://github.com/tensorflow/tensorflow/blob/v2.0.0/tensorflow/contrib/makefile/rename_protobuf.sh,
tensorflow/tensorflow#16104

Testing locally this fixes both crashes when linking in multiple versions of protobuf
and fixes `DescriptorPool` clashes as well (e.g. Python and Native code import different versions of the same message).
    @rowillia @acozzette
    rowillia authored and acozzette committed Jan 22, 2022
    Copy the full SHA
    18f8cd0 View commit details
    Browse the repository at this point in the history