Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Php & Ruby Cherry Picks for 3.17.1 #8632

Merged
merged 4 commits into from May 19, 2021
Merged

Php & Ruby Cherry Picks for 3.17.1 #8632

merged 4 commits into from May 19, 2021

Commits on May 19, 2021

  1. Some more updates to PHP testing infrastructure (protocolbuffers#8576) 

    * WIP.

* Added build config for all of the tests.

* Use ../src/protoc if it is available, for cases where Bazel isn't available.

* Added test_php.sh.

* Fix for the broken macOS tests.

* Move all jobs to use php80 instead of lots of separate jobs.

* Only pass -t flag if we are running in a terminal.

* Updated php_all job to use new Docker stuff.
    @haberman
    haberman committed May 19, 2021
    Copy the full SHA
    f72b0e3 View commit details
    Browse the repository at this point in the history

  2. Fixed PHP memory leaks and arginfo errors (protocolbuffers#8614) 

    * Fixed a bunch of incorrect arginfo and a few incorrect error messages.

* Passes mem check test with no leaks!

* WIP.

* Fix build warning that was causing Bazel build to fail.

* Added compatibility code for PHP <8.0.

* Added test_valgrind target and made tests Valgrind-clean.

* Updated Valgrind test to fail if memory leaks are detected.

* Removed intermediate shell script so commands are easier to cut, paste, and modify.

* Passing all Valgrind tests!

* Hoist addref into ObjCache_Get().

* Removed special case of map descriptors by keying object map on upb_msgdef.

* Removed all remaining RETURN_ZVAL() macros.

* Removed all explicit reference add/del operations.

* Added REFCOUNTING.md to Makefile.am.
    @haberman
    haberman committed May 19, 2021
    Copy the full SHA
    9fb09a0 View commit details
    Browse the repository at this point in the history

  3. Updated upb version and fixed PHP to not get unset message field. (pr… 

    …otocolbuffers#8621)

* Updated upb version and fixed PHP to not get unset message field.

* Updated changelog.

* Fixed preproc test to handle old versions of Clang withot __has_attribute().

* A second try at fixing __has_attribute().

* Copy __has_attribute() fix to cc file also.

* Updated failure list for PHP for fixed test.
    @haberman
    haberman committed May 19, 2021
    Copy the full SHA
    b4303a7 View commit details
    Browse the repository at this point in the history

  4. Updated version of upb for Ruby (protocolbuffers#8624) 

    * Updated upb.

* Preserve legacy behavior for unset messages.

* Updated failure list.

* Updated CHANGES.txt.

* Added erroneously-deleted test file.

* Fixed condition on compatibility code.

* Re-introduced deleted file again, and fixed Rakefile to not delete it.

* Fix generation of test protos.
    @haberman
    haberman committed May 19, 2021
    Copy the full SHA
    521affa View commit details
    Browse the repository at this point in the history