Fix newly appeared -Wunused-parameter #8584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please, consider cherry-picking this fix into 3.17 branch.
|
@georgthegreat If you can rebase this onto the 3.17.x branch then I can merge it there directly. |
georgthegreat
added a commit
to georgthegreat/protobuf
that referenced
this pull request
May 8, 2021
This is protocolbuffers#8584 applied to 3.17.x
|
I had to create new PR over 3.17.x. You can find at #8587. You can close this if you prefer merging from 3.17.x instead of this PR. |
acozzette
pushed a commit
that referenced
this pull request
May 10, 2021
This is #8584 applied to 3.17.x
|
Thanks, @georgthegreat. I merged the other PR so I will go ahead and close this one. The other fix will make it into master soon when I merge 3.17.x into master. |
|
Ok, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, consider cherry-picking this fix into 3.17 branch.