Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SEGV when users pass nil messages. This also disallows nil in RepeatedField or Map. #8363

Merged
merged 2 commits into from
Mar 3, 2021

Conversation

haberman
Copy link
Member

@haberman haberman commented Mar 2, 2021

We cannot have nil messages in repeated fields or maps, it is semantically undefined what it would mean to serialize that. It is a bug that nil messages were ever allowed.

Fixes: #8359

@haberman haberman requested a review from acozzette March 2, 2021 20:46
@google-cla google-cla bot added the cla: yes label Mar 2, 2021
@haberman haberman changed the base branch from master to 3.15.x March 2, 2021 20:46
@haberman haberman merged commit cf7d81f into protocolbuffers:3.15.x Mar 3, 2021
This was referenced Mar 14, 2021
@haberman haberman deleted the ruby-nil-fix branch April 20, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEGV in Ruby when initializing with nil
3 participants