Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Make shared libraries be able to link to MSVC static runtime libraries, so that VC runtime is not required." #6914

Merged
merged 9 commits into from Nov 20, 2019
Merged

Revert "Make shared libraries be able to link to MSVC static runtime libraries, so that VC runtime is not required." #6914

merged 9 commits into from Nov 20, 2019

Commits on Nov 19, 2019

  1. Update CHANGES.txt with 3.11.0-RC1 release notes

    @rafi-kamal
    rafi-kamal committed Nov 19, 2019
    Copy the full SHA
    7471a0a View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2019

  1. Update the description of Python changes

    @rafi-kamal
    rafi-kamal committed Nov 20, 2019
    Copy the full SHA
    bc0e3c9 View commit details
    Browse the repository at this point in the history

  2. Expand the section on C# Proto2 support 

    Co-Authored-By: ObsidianMinor <ObsidianMinor@users.noreply.github.com>
    @rafi-kamal @ObsidianMinor
    rafi-kamal and ObsidianMinor committed Nov 20, 2019
    Copy the full SHA
    7ab5173 View commit details
    Browse the repository at this point in the history

  3. Removed the C# Proto2 feature implementation PR in favour of the gett… 

    …ing strated doc.
    @rafi-kamal
    rafi-kamal committed Nov 20, 2019
    Copy the full SHA
    2ac5df2 View commit details
    Browse the repository at this point in the history

  4. Updated release notes for Obj-C

    @rafi-kamal
    rafi-kamal committed Nov 20, 2019
    Copy the full SHA
    d0dbd19 View commit details
    Browse the repository at this point in the history

  5. Removed unnecessary/internal changes from Java and Javascript

    @rafi-kamal
    rafi-kamal committed Nov 20, 2019
    Copy the full SHA
    2b6acbd View commit details
    Browse the repository at this point in the history

  6. Revert "Make shared libraries be able to link to MSVC static runtime … 

    …libraries, so that VC runtime is not required."

This reverts commit 129a7c8. We are
seeing errors when building Python release artifacts in Windows:
" error LNK2038: mismatch detected for 'RuntimeLibrary': value
'MD_DynamicRelease' doesn't match value 'MT_StaticRelease' in
descriptor.obj".
    @rafi-kamal
    rafi-kamal committed Nov 20, 2019
    Copy the full SHA
    677b77f View commit details
    Browse the repository at this point in the history

  7. Merge branch '3.11.x' of https://github.com/rafi-kamal/protobuf into … 

    …3.11.x
    @rafi-kamal
    rafi-kamal committed Nov 20, 2019
    Copy the full SHA
    ad72345 View commit details
    Browse the repository at this point in the history

  8. Remove the line from CHANGES.txt that mentions protocolbuffers#6780

    @rafi-kamal
    rafi-kamal committed Nov 20, 2019
    Copy the full SHA
    481f676 View commit details
    Browse the repository at this point in the history