Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf version #6898

Merged
merged 1 commit into from Nov 16, 2019

Conversation

rafi-kamal
Copy link
Contributor

No description provided.

@rafi-kamal
Copy link
Contributor Author

@TeBoring some the PHP files have changed. Do you know why?

@TeBoring
Copy link
Contributor

TeBoring commented Nov 15, 2019 via email

@rafi-kamal
Copy link
Contributor Author

The Bazel tests are failing with the following error:

ERROR: /tmpfs/src/github/protobuf/examples/BUILD:73:1: //:addressbook_java_lite_proto depends on @com_google_protobuf_javalite//:javalite_toolchain in repository @com_google_protobuf_javalite which failed to fetch. no such package '@com_google_protobuf_javalite//': java.io.IOException: Error downloading [https://github.com/protocolbuffers/protobuf/archive/javalite.zip] to /tmpfs/tmp/bazel/external/com_google_protobuf_javalite/javalite.zip: GET returned 404 Not Found

@ejona86 could this be related to the javalite stuffs you have been working on?

@rafi-kamal
Copy link
Contributor Author

Actually, the failure seems to be unrelated to Eric's change (grpc/grpc-java#6424). That change was submitting yesterday, our tests started failing from this noon (https://g3c.corp.google.com/results/invocations;query=protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fbazel%2Fpresubmit).

@rafi-kamal
Copy link
Contributor Author

Looks like our javalite branch got vanished somehow. I've restored the branch, hopefully that will fix the error.

@rafi-kamal rafi-kamal merged commit 3cc55d6 into protocolbuffers:master Nov 16, 2019
rafi-kamal added a commit that referenced this pull request Nov 19, 2019
@rafi-kamal rafi-kamal deleted the 3.11.x-201911151144 branch November 21, 2019 18:33
nlhien pushed a commit to nlhien/protobuf that referenced this pull request Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants