Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby lazy wrappers optimization #6797

Merged
merged 8 commits into from Nov 7, 2019
Merged

Ruby lazy wrappers optimization #6797

merged 8 commits into from Nov 7, 2019

Commits on Oct 21, 2019

  1. WIP: first steps towards lazily creating wrappers.

    @haberman
    haberman committed Oct 21, 2019
    Copy the full SHA
    969d245 View commit details
    Browse the repository at this point in the history

  2. Tests pass for all common operations. 

    A few things that don't work or aren't tested yet:
- wrappers at the top level
- equality checking for not-yet-expanded wrappers.
    @haberman
    haberman committed Oct 21, 2019
    Copy the full SHA
    9cfb12b View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2019

  1. Fixed equality, and extended to repeated fields and maps.

    @haberman
    haberman committed Oct 29, 2019
    Copy the full SHA
    bd253f0 View commit details
    Browse the repository at this point in the history

  2. Nearly all known cases (map, repeated field, and top-level) have been… 

    … addressed.

The only case that doesn't work is decoding a wrapper type from JSON
at the top level.  This doesn't make sense and probably no users do it
I changed it to throw.
    @haberman
    haberman committed Oct 29, 2019
    Copy the full SHA
    8393d48 View commit details
    Browse the repository at this point in the history

  3. Fixed the oneof case for lazy wrappers.

    @haberman
    haberman committed Oct 29, 2019
    Copy the full SHA
    e8c67e1 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2019

  1. Merge branch 'master' into ruby-lazy-wrappers

    @haberman
    haberman committed Oct 30, 2019
    Copy the full SHA
    aae5c49 View commit details
    Browse the repository at this point in the history

  2. Fixed conformance test regression: empty string wrapper.

    @haberman
    haberman committed Oct 30, 2019
    Copy the full SHA
    5f25400 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2019

  1. Fixed the case of multi-line strings in JSON.

    @haberman
    haberman committed Oct 31, 2019
    Copy the full SHA
    781d696 View commit details
    Browse the repository at this point in the history