Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C# Proto2 feature : Extensions #5350

Merged
merged 27 commits into from May 3, 2019
Merged

C# Proto2 feature : Extensions #5350

merged 27 commits into from May 3, 2019

Commits on May 2, 2019

  1. Compiler changes (extensions)

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    782db22 View commit details
    Browse the repository at this point in the history

  2. Generated changes (extensions)

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    467c4e6 View commit details
    Browse the repository at this point in the history

  3. Library changes (extensions)

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    479ae41 View commit details
    Browse the repository at this point in the history

  4. Adjusted a summary to indicate ContainingType can be null for extensions

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    73b6aec View commit details
    Browse the repository at this point in the history

  5. Compiler changes (custom option review + access level review)

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    6654bf5 View commit details
    Browse the repository at this point in the history

  6. Generated code changes (custom options + access review)

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    c7966d7 View commit details
    Browse the repository at this point in the history

  7. Library changes (custom options + access review)

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    b733dd3 View commit details
    Browse the repository at this point in the history

  8. Support C# 6 with library changes

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    f405b3b View commit details
    Browse the repository at this point in the history

  9. Access HasValue by property

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    6392ce4 View commit details
    Browse the repository at this point in the history

  10. Set access level of all extension classes to internal (revert in next… 

    … PR)
    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    a61bbee View commit details
    Browse the repository at this point in the history

  11. Added null checks to custom options

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    a281bee View commit details
    Browse the repository at this point in the history

  12. Rebase on master and regenerate Conformance

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    2ae12df View commit details
    Browse the repository at this point in the history

  13. Removed second dictionary from ExtensionSet

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    ceb0257 View commit details
    Browse the repository at this point in the history

  14. Rebased compiler changes

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    7ca6478 View commit details
    Browse the repository at this point in the history

  15. Rebased generated code changes

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    3ce1d14 View commit details
    Browse the repository at this point in the history

  16. Rebased library changes + review changes

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    f46c17d View commit details
    Browse the repository at this point in the history

  17. Add more safety checks to extension accessors

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    bc5b673 View commit details
    Browse the repository at this point in the history

  18. Remove instances where extension sets were unnecessarily allocated

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    c4857ba View commit details
    Browse the repository at this point in the history

  19. Remove cleared items from sets 

    Empty sets are now made null
IExtensionMessage -> IExtendableMessage
    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    8ba23fe View commit details
    Browse the repository at this point in the history

  20. Remove dead code from IExtensionValue impls

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    a632607 View commit details
    Browse the repository at this point in the history

  21. Clean both repeated and single value extensions

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    2c1044d View commit details
    Browse the repository at this point in the history

  22. Add GetOrRegister method for repeated fields and allow clearing repea… 

    …ted extensions
    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    ade12cf View commit details
    Browse the repository at this point in the history

  23. Add type safe ClearExtension methods, remove non-generic IExtendableM… 

    …essage interface.
    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    b7f9176 View commit details
    Browse the repository at this point in the history

  24. Simplify ExtensionSet.TryMergeFieldFrom

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    75c6d5f View commit details
    Browse the repository at this point in the history

  25. Rebase on master to resolve conflicts

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    b72a3ff View commit details
    Browse the repository at this point in the history

  26. Fix Makefile.am

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    896f4d9 View commit details
    Browse the repository at this point in the history

  27. Add ObjectIntPair to Makefile.am

    @ObsidianMinor
    ObsidianMinor committed May 2, 2019
    Copy the full SHA
    957873f View commit details
    Browse the repository at this point in the history