Allow builders to return default instance in Java #16655
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rationale: I was investigating allocations during parsing where a lot of empty messages were present and realized that each of these empty messages was a newly allocated instance, when it would be more memory efficient to reuse the default instance each time.
solution: add a default flag to the builder which is invalidated onChange. then conditionally return the default instance if that flag is true.
note: I had to bring back some logic removed in c0d08bd in order for the schema flow to work correctly since it was using toBuilder and expecting a new instance, not the default instance.