Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP: The mirror repository used to host protobuf for packagist has not been synced #9746

Closed
dwsupplee opened this issue Apr 5, 2022 · 5 comments
Assignees
Labels

Comments

@dwsupplee
Copy link
Contributor

dwsupplee commented Apr 5, 2022

This is causing an issue with installations via composer, as it is allowing PHP 5.5/5.6 to install versions such as v3.20.0 which actually require PHP >=7.0.

For example, due to the inclusion of return type hinting:

PHP Parse error:  syntax error, unexpected ':', expecting ';' or '{' in /tmpfs/src/github/google-cloud-php/vendor/google/protobuf/src/Google/Protobuf/Internal/RepeatedField.php on line 240
@bshaffer
Copy link
Contributor

cc @haberman
Unfortunately this one is breaking anyone using protobuf on < PHP 7.0. This is because the latest versions say they support PHP 5.5 but they're actually only compatible with PHP 7+.

We need to fix composer.json to be correct and then remove those tags (because composer will always pull them in for PHP 5.5 / 5.6 even after we fix composer.json because they will be seen as the latest compatible versions of this library for those PHP versions).

Until we do that, protobuf will be completely broken for anyone on PHP 5.5 and 5.6

@perezd perezd assigned perezd and haberman and unassigned perezd Apr 18, 2022
@perezd
Copy link
Contributor

perezd commented Apr 18, 2022

@haberman is this something that we missed as part of a release step?

@bshaffer
Copy link
Contributor

I am submitting googleapis/gax-php#382 to exclude the broken version of protobuf until we can get this resolved

@bshaffer
Copy link
Contributor

We are also looking at php/release.sh, because this doesn't seem to be getting called

@haberman
Copy link
Member

I think the underlying problem was fixed in #9832 (with a related fix in #9819).

Separately, we need to yank the 3.20.0 release since it advertises compatibility with PHP 5.5 but is not actually compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants