Skip to content

Commit

Permalink
internal/benchmarks: make download_benchdata print an error
Browse files Browse the repository at this point in the history
Currently, the script fails, and not with a good error message.

related to golang/protobuf#1524

Change-Id: Ia27a895a7ae2f6349bb1262936e4428fa485bb92
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/538955
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Lasse Folger <lassefolger@google.com>
  • Loading branch information
stapelberg authored and lfolger committed Nov 3, 2023
1 parent f4a6c1f commit 9492118
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions internal/benchmarks/download_benchdata.bash
Expand Up @@ -7,11 +7,6 @@ cd "$(git rev-parse --show-toplevel)"
mkdir -p .cache/benchdata
cd .cache/benchdata

# Download small benchmark datasets.
PROTOBUF_VERSION=v3.11.4
curl -s -O https://raw.githubusercontent.com/protocolbuffers/protobuf/$PROTOBUF_VERSION/benchmarks/datasets/google_message1/proto2/dataset.google_message1_proto2.pb
curl -s -O https://raw.githubusercontent.com/protocolbuffers/protobuf/$PROTOBUF_VERSION/benchmarks/datasets/google_message1/proto3/dataset.google_message1_proto3.pb
curl -s -O https://raw.githubusercontent.com/protocolbuffers/protobuf/$PROTOBUF_VERSION/benchmarks/datasets/google_message2/dataset.google_message2.pb

# Download large benchmark datasets.
curl -s https://storage.googleapis.com/protobuf_opensource_benchmark_data/datasets.tar.gz | tar zx
echo "This script needs to be updated to work with https://github.com/google/fleetbench" >&2
echo "See https://github.com/golang/protobuf/issues/1570" >&2
exit 1

0 comments on commit 9492118

Please sign in to comment.