This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
run go vet and staticcheck in go-check #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
go-vet-staticcheck
branch
from
45cb0aa
to
644b53b
Compare
mvdan
approved these changes
Mar 7, 2021
workflow-templates/go-check.yml
Outdated
| if: ${{ success() || failure() }} | ||
| run: | | ||
| set -o pipefail | ||
| staticcheck ./... | sed -e "s/\(.*\)\.go/.\/\1.go/g" |
There was a problem hiding this comment.
perhaps document the sed with a TODO comment pointing at the setup-go issue.
Also, I think it would be clearer to use single quotes for regexps, so that shell escaping doesn't play a part. You can also use a different separator to not have to escape the slash:
sed -e 's@\(.*\)\.go@./\1.go/g'
I also wonder if you want [^ ]+\.go for filenames, as that might have fewer false positives like foo bar.go.
There was a problem hiding this comment.
I tried [^ ]+\.go, but sed doesn't like it.
marten-seemann
force-pushed
the
go-vet-staticcheck
branch
from
644b53b
to
be1978c
Compare
mvdan
approved these changes
Mar 7, 2021
This was referenced Mar 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6.
Run
go vetandstaticcheckwithout any involvement of golangci-lint. golangci-lint is a quite complicated beast, and we're probably better off just running the tools ourselves.See marten-seemann-test/target#33 for a demo of this workflow.
This has been blocked by the problems with staticcheck for way too long. I'm now using a regex to fix the output, such that GitHub Annotations will pick up the path. All we need to do is transform
cmd/main.go:5:6: func build is unused (U1000)to./cmd/main.go:5:6: func build is unused (U1000).